Skip to content

fix: set resource limits on Loki pods #11940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexghr merged 1 commit into from
Feb 12, 2025
Merged

fix: set resource limits on Loki pods #11940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions spartan/metrics/values/kind.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,26 @@ loki:
period: 24h
object_store: filesystem # we're storing on filesystem so there's no real persistence here.
schema: v13
limits_config:
ingestion_rate_mb: 4
ingestion_burst_size_mb: 6
max_global_streams_per_user: 5000
max_query_series: 500
max_query_lookback: 24h
max_query_length: 1h
max_query_parallelism: 8
query_timeout: 3m
singleBinary:
replicas: 1
resources:
requests:
cpu: 100m
memory: 256Mi
limits:
cpu: 2000m
memory: 2Gi
persistence:
size: 10Gi
read:
replicas: 0
backend:
Expand Down
2 changes: 1 addition & 1 deletion yarn-project/end-to-end/src/spartan/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ export async function startPortForward({
if (str.includes('Starting port forward')) {
logger.info(str);
} else {
logger.debug(str);
Copy link
Collaborator

@ludamad ludamad Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why even log if silent?

logger.silent(str);
}
});
process.stderr?.on('data', data => {
Expand Down