Skip to content

chore: Request txs in prover-node after each block finishes #11749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spalladino merged 1 commit into from
Feb 5, 2025
Merged

chore: Request txs in prover-node after each block finishes #11749

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions yarn-project/prover-node/src/prover-node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import { type ContractDataSource } from '@aztec/circuits.js';
import { compact } from '@aztec/foundation/collection';
import { memoize } from '@aztec/foundation/decorators';
import { createLogger } from '@aztec/foundation/log';
import { RunningPromise } from '@aztec/foundation/running-promise';
import { DateProvider } from '@aztec/foundation/timer';
import { type Maybe } from '@aztec/foundation/types';
import { type P2P } from '@aztec/p2p';
Expand Down Expand Up @@ -67,6 +68,9 @@ export class ProverNode implements ClaimsMonitorHandler, EpochMonitorHandler, Pr
private options: ProverNodeOptions;
private metrics: ProverNodeMetrics;

private txFetcher: RunningPromise;
private lastBlockNumber: number | undefined;

public readonly tracer: Tracer;

constructor(
Expand Down Expand Up @@ -97,6 +101,7 @@ export class ProverNode implements ClaimsMonitorHandler, EpochMonitorHandler, Pr

this.metrics = new ProverNodeMetrics(telemetryClient, 'ProverNode');
this.tracer = telemetryClient.getTracer('ProverNode');
this.txFetcher = new RunningPromise(() => this.checkForTxs(), this.log, this.options.txGatheringIntervalMs);
}

public getP2P() {
Expand Down Expand Up @@ -202,6 +207,7 @@ export class ProverNode implements ClaimsMonitorHandler, EpochMonitorHandler, Pr
* This method returns once the prover node has deposited an initial bond into the escrow contract.
*/
async start() {
this.txFetcher.start();
await this.bondManager.ensureBond();
this.epochsMonitor.start(this);
this.claimsMonitor.start(this);
Expand All @@ -213,6 +219,7 @@ export class ProverNode implements ClaimsMonitorHandler, EpochMonitorHandler, Pr
*/
async stop() {
this.log.info('Stopping ProverNode');
await this.txFetcher.stop();
await this.epochsMonitor.stop();
await this.claimsMonitor.stop();
await this.prover.stop();
Expand Down Expand Up @@ -312,6 +319,22 @@ export class ProverNode implements ClaimsMonitorHandler, EpochMonitorHandler, Pr
return this.l2BlockSource.getL1Constants();
}

/** Monitors for new blocks and requests their txs from the p2p layer to ensure they are available for proving. */
@trackSpan('ProverNode.checkForTxs')
private async checkForTxs() {
const blockNumber = await this.l2BlockSource.getBlockNumber();
if (this.lastBlockNumber === undefined || blockNumber > this.lastBlockNumber) {
const block = await this.l2BlockSource.getBlock(blockNumber);
if (!block) {
return;
}
const txHashes = block.body.txEffects.map(tx => tx.txHash);
this.log.verbose(`Fetching ${txHashes.length} for block number ${blockNumber} from coordination`);
await this.coordination.getTxsByHash(txHashes); // This stores the txs in the tx pool, no need to persist them here
this.lastBlockNumber = blockNumber;
}
}

@trackSpan('ProverNode.gatherEpochData', epochNumber => ({ [Attributes.EPOCH_NUMBER]: Number(epochNumber) }))
private async gatherEpochData(epochNumber: bigint) {
// Gather blocks for this epoch and their txs
Expand Down