feat: exploring contract class logs as fields#11632
Closed
MirandaWood wants to merge 51 commits intomasterfrom
Closed
feat: exploring contract class logs as fields#11632MirandaWood wants to merge 51 commits intomasterfrom
MirandaWood wants to merge 51 commits intomasterfrom
Conversation
MirandaWood
requested review from
IlyasRidhuan,
fcarreiro and
jeanmon
as code owners
Contributor
Changes to circuit sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
Merged
TomAFrench
added a commit
that referenced
this pull request
Feb 13, 2025
Wee PR to fix some things I discovered in #11632: - We don't actually support multiple blobs per block in ts. The call in `data_retrieval` assumes we have just one per block and doesn't push the blob buffers together. I added a fn to combine them. - Also, the `archiver.test` didn't support multiple blobs and would fail when we had more than one; I edited the helper fns. - I removed the range checks in `components.nr` for a (small) gate count improvement. - In `components.nr` we were checking the incorrect index for public and private logs: ```rust let index = offset + j * PUBLIC_LOG_SIZE_IN_FIELDS + k; if index < array_len { assert_eq(tx_effects_hash_input[index], log[k]); assert_eq(tx_effects_hash_input[index], log[k]); } ``` Where we should be checking whether `j * PUBLIC_LOG_SIZE_IN_FIELDS + k` is less than `array_len` - no inclusion of `offset`. - I noticed that we were sometimes spending 100k+ gates on `array_merge`. I changed it to construct the array in unconstrained, then check each item against either the left or right array. We could also use `is_empty` on each item, but depending on `T` that could be expensive, and I don't think we have a use case where we must check each item for emptiness. --------- Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Contributor
Author
|
Closing - we went with hashing: #12061 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just testing out what breaks, what is massively slow, does CI build, how many more gates we have etc.WILL NOT WORK! DO NOT MERGE! DON'T EVEN THINK ABOUT IT!Works as of last week!