Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merged
LHerskind
force-pushed
the
lh/11520
branch
2 times, most recently
from
f3e264f to
f4e5f8d
Compare
Maddiaa0
reviewed
Feb 3, 2025
|
|
||
| bytes32 private constant STAKING_SLOT = keccak256("aztec.core.staking.storage"); | ||
|
|
||
| function initialize( |
Member
There was a problem hiding this comment.
A little strange this is ordered differently to the initialize args order
Maddiaa0
reviewed
Feb 3, 2025
Member
Maddiaa0
left a comment
Maddiaa0
left a comment
There was a problem hiding this comment.
looks good to me but now needs rebase
Maddiaa0
approved these changes
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11519. Minor oddities can be encountered, if the events are in the library, they won't be part of the rollup contract since the library is external. Therefore events and structs are kept in the interface for simple access.