Skip to content

fix: stale selector comments #11311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benesjan merged 1 commit into from
Jan 17, 2025
Merged

fix: stale selector comments #11311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions yarn-project/foundation/src/abi/event_selector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,10 @@ export class EventSelector extends Selector {

/**
* Create a Selector instance from a hex-encoded string.
* The input 'address' should be prefixed with '0x' or not, and have exactly 64 hex characters.
* Throws an error if the input length is invalid or address value is out of range.
*
* @param selector - The hex-encoded string representing the Selector.
* @returns An Selector instance.
* @throws If the selector length is invalid.
*/
static fromString(selector: string) {
const buf = fromHex(selector);
Expand Down
3 changes: 1 addition & 2 deletions yarn-project/foundation/src/abi/function_selector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,11 +82,10 @@ export class FunctionSelector extends Selector {

/**
* Create a Selector instance from a hex-encoded string.
* The input 'address' should be prefixed with '0x' or not, and have exactly 64 hex characters.
* Throws an error if the input length is invalid or address value is out of range.
*
* @param selector - The hex-encoded string representing the Selector.
* @returns An Selector instance.
* @throws If the selector length is invalid.
*/
static fromString(selector: string) {
const buf = fromHex(selector);
Expand Down
Loading