Skip to content

fix: remove bb path override in cli-wallet #11280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saleel merged 2 commits into from
Jan 17, 2025
Merged

fix: remove bb path override in cli-wallet #11280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
344f97e
fix: use native bb in cli-wallet
saleel Jan 16, 2025
98e66eb
Merge branch 'master' into saleel/fix-wallet
saleel Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions aztec-up/bin/aztec-wallet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,20 +3,9 @@ set -euo pipefail

export SKIP_PORT_ASSIGNMENT=1
export WALLET_DATA_DIRECTORY=$(dirname $0)/wallet-data
export BB_WORKING_DIRECTORY=$(dirname $0)/bb-workdir

if [ -z "${BB_BINARY_PATH:-}" ]; then
export BB_BINARY_PATH=$HOME/.bb/bb
fi

if [ ! -f $BB_BINARY_PATH ]; then
echo "bb binary does not exist at $BB_BINARY_PATH. Set BB_BINARY_PATH environment variable to the path of the bb binary."
exit 1
fi

export ENV_VARS_TO_INJECT="WALLET_DATA_DIRECTORY SSH_AUTH_SOCK PXE_PROVER_ENABLED BB_BINARY_PATH BB_WORKING_DIRECTORY"

mkdir -p $BB_WORKING_DIRECTORY
mkdir -p $WALLET_DATA_DIRECTORY

$(dirname $0)/.aztec-run aztecprotocol/cli-wallet $@
4 changes: 3 additions & 1 deletion docs/docs/guides/developer_guides/smart_contracts/profiling_transactions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,10 @@ aztec-wallet send transfer -ca token --args accounts:owner 40 -f user

Instead of sending the above transaction, you can simulate it by running the `simulate` command with the same parameters, and then add a `--profile` flag to profile the gate count of each private function in the transaction.

For the time being, you also need to set `BB_BINARY_PATH` and `BB_WORKING_DIRECTORY` environment variables with the below values.

```bash
aztec-wallet simulate --profile transfer -ca token --args accounts:owner 40 -f user
BB_BINARY_PATH=/usr/src/barretenberg/cpp/build/bin/bb BB_WORKING_DIRECTORY=~/.bb/work-dir aztec-wallet simulate --profile transfer -ca token --args accounts:owner 40 -f user
```

This will print the following results after some time:
Expand Down
Loading