Skip to content

chore: Add circuit input checks to bootstrap.sh #11261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nventuro merged 3 commits into from
Jan 17, 2025
Merged

chore: Add circuit input checks to bootstrap.sh #11261

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c80c36
chore: add tests for circuit inputs to bootstrap.sh
TomAFrench Jan 16, 2025
890c2a8
.
TomAFrench Jan 16, 2025
276b1e8
Update bootstrap.sh
TomAFrench Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions noir-projects/noir-protocol-circuits/bootstrap.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,9 @@ function build {
return $code
}

# We don't blindly execute all circuits as some will have no `Prover.toml`.
CIRCUITS_TO_EXECUTE="private-kernel-init private-kernel-inner private-kernel-reset private-kernel-tail-to-public private-kernel-tail rollup-base-private rollup-base-public rollup-block-root rollup-block-merge rollup-merge rollup-root"

function test {
set -eu
name=$(basename "$PWD")
Expand All @@ -146,6 +149,10 @@ function test {

RAYON_NUM_THREADS= $NARGO test --skip-brillig-constraints-check
cache_upload_flag $name-tests-$CIRCUITS_HASH

for circuit in $CIRCUITS_TO_EXECUTE; do
$NARGO execute --program-dir noir-projects/noir-protocol-circuits/crates/$circuit --silence-warnings --skip-brillig-constraints-check
done
}

export -f compile test build
Expand All @@ -171,6 +178,9 @@ case "$CMD" in
$NARGO test --list-tests --silence-warnings | while read -r package test; do
echo "noir-projects/scripts/run_test.sh noir-protocol-circuits $package $test"
done
for circuit in $CIRCUITS_TO_EXECUTE; do
echo "$NARGO execute --program-dir noir-projects/noir-protocol-circuits/crates/$circuit --silence-warnings --skip-brillig-constraints-check"
done
;;
"ci")
parallel --tag --line-buffered {} ::: build test
Expand Down
Loading