Skip to content

chore: refactor Solidity Transcript and improve error handling in sol_honk flow #11158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maramihali merged 5 commits into from
Jan 13, 2025
Merged

chore: refactor Solidity Transcript and improve error handling in sol_honk flow #11158

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0b0513f
refactor solidity
Jan 10, 2025
9349c84
cleanup
Jan 10, 2025
2b17f69
cleanup
Jan 10, 2025
340a444
remove unused import and make some errors more verbose
Jan 10, 2025
35924b9
Merge branch 'master' into mm/contract-cleanupp
Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion barretenberg/acir_tests/sol-test/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,10 @@ if (!testingHonk) {
}

var output = JSON.parse(solc.compile(JSON.stringify(compilationInput)));
if (output.errors.some((e) => e.type == "Error")) {
if (output.errors.some((e) => e.severity == "error")) {
throw new Error(JSON.stringify(output.errors, null, 2));
}

const contract = output.contracts["Test.sol"]["Test"];
const bytecode = contract.evm.bytecode.object;
const abi = contract.abi;
Expand Down
Loading