Skip to content

chore: Sanity checking of proving job IDs #11134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PhilWindle merged 2 commits into from
Jan 9, 2025
Merged

chore: Sanity checking of proving job IDs #11134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6a857d
Proving Job Id sanity check
PhilWindle Jan 9, 2025
a9daf6f
Check array length
PhilWindle Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion yarn-project/circuit-types/src/interfaces/proving-job.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,11 @@ export const makeProvingJobId = (epochNumber: number, type: ProvingRequestType,

export const getEpochFromProvingJobId = (id: ProvingJobId) => {
const components = id.split(':');
return +components[0];
const epochNumber = components.length < 1 ? Number.NaN : parseInt(components[0], 10);
if (!Number.isSafeInteger(epochNumber) || epochNumber < 0) {
throw new Error(`Proving Job ID ${id} does not contain valid epoch`);
}
return epochNumber;
};

export type ProvingJob = z.infer<typeof ProvingJob>;
Expand Down
3 changes: 2 additions & 1 deletion yarn-project/prover-client/src/proving_broker/broker_prover_facade.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {
ProvingRequestType,
type PublicInputsAndRecursiveProof,
type ServerCircuitProver,
makeProvingJobId,
} from '@aztec/circuit-types';
import {
type AVM_PROOF_LENGTH_IN_FIELDS,
Expand Down Expand Up @@ -564,6 +565,6 @@ export class BrokerCircuitProverFacade implements ServerCircuitProver {

private generateId(type: ProvingRequestType, inputs: { toBuffer(): Buffer }, epochNumber = 0) {
const inputsHash = sha256(inputs.toBuffer());
return `${epochNumber}:${ProvingRequestType[type]}:${inputsHash.toString('hex')}`;
return makeProvingJobId(epochNumber, type, inputsHash.toString('hex'));
}
}