fix: don't U128::from_integer(u128)#10865
Merged
TomAFrench merged 1 commit intomasterfrom Dec 19, 2024
Merged
Conversation
Contributor
Changes to public function bytecode sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
TomAFrench
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Noir we are removing the (private) built-ins
as_fieldandfrom_field, which allowed casting any type to and from Field by truncating its bits. This uncovered two bugs where we were doingU128::from_integer(x)withxitself being aU128. That code won't compile anymore (and I think it was incorrect) so I'm doing those changes in this PR.See noir-lang/noir#6845