Skip to content

feat: better initialization for permutation mapping components #10750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ledwards2225 merged 9 commits into from
Dec 17, 2024
Merged

feat: better initialization for permutation mapping components #10750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
624ba85
better initialization scheme for permutation mapping components
ledwards2225 Dec 15, 2024
1022c11
Merge branch 'master' into lde/perm_map_init
ledwards2225 Dec 15, 2024
5068390
try to fix build
ledwards2225 Dec 16, 2024
57810a4
fix build
ledwards2225 Dec 16, 2024
7883d1d
correct num threads calculation
ledwards2225 Dec 16, 2024
0bf0ad0
Merge branch 'master' into lde/perm_map_init
ledwards2225 Dec 16, 2024
6d7c8c5
cleanup
ledwards2225 Dec 16, 2024
46564ce
unrelated updates to default behavior for reset acir tests
ledwards2225 Dec 16, 2024
41c5d71
Merge branch 'master' into lde/perm_map_init
ledwards2225 Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion barretenberg/acir_tests/regenerate_verify_honk_proof_inputs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ PROGRAM=assert_statement
# the program containing the recursive verifier
RECURSIVE_PROGRAM=verify_honk_proof

./reset_acir_tests.sh --rebuild-nargo --programs "$PROGRAM"
./reset_acir_tests.sh --programs "$PROGRAM"
cd "acir_tests/$PROGRAM"

TOML_DIR=../../../../noir/noir-repo/test_programs/execution_success/"$RECURSIVE_PROGRAM"
Expand Down
15 changes: 8 additions & 7 deletions barretenberg/acir_tests/reset_acir_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@ set -e
# Run from within barretenberg/acir_tests

# Initialize variables for flags
REBUILD_NARGO_FLAG=""
REBUILD_NARGO_FLAG=true
PROGRAMS=""

# Parse the arguments
while [[ "$#" -gt 0 ]]; do
case $1 in
--rebuild-nargo)
Copy link
Contributor

@lucasxia01 lucasxia01 Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this

REBUILD_NARGO_FLAG="--rebuild-nargo"
--no-rebuild-nargo)
REBUILD_NARGO_FLAG=false
;;
--programs)
shift
Expand All @@ -26,12 +26,13 @@ while [[ "$#" -gt 0 ]]; do
shift
done

# Clean and rebuild noir, then compile the test programs if --rebuild-nargo flag is set
cd ../../noir/noir-repo

if [[ -n "$REBUILD_NARGO_FLAG" ]]; then
cd ../../noir/noir-repo
# Clean and rebuild noir unless --no-rebuild-nargo is specified, then compile the test programs
if [[ "$REBUILD_NARGO_FLAG" == true ]]; then
cargo clean
noirup -p .
else
echo "Skipping noir nargo build."
fi

# Rebuild test programs with rebuild.sh
Expand Down
Loading