Skip to content

fix: use correct size for databus_id #10673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ledwards2225 merged 1 commit into from
Dec 13, 2024
Merged

fix: use correct size for databus_id #10673

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions barretenberg/cpp/src/barretenberg/ultra_honk/decider_proving_key.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,11 +177,7 @@ template <IsUltraFlavor Flavor> class DeciderProvingKey_ {
proving_key.polynomials.return_data_read_tags =
Polynomial(MAX_DATABUS_SIZE, proving_key.circuit_size);

// TODO(https://github.com/AztecProtocol/barretenberg/issues/1107): Restricting databus_id to
// databus_size leads to failure.
// const size_t databus_size = std::max({ calldata.size(), secondary_calldata.size(),
// return_data.size() });
proving_key.polynomials.databus_id = Polynomial(proving_key.circuit_size, proving_key.circuit_size);
proving_key.polynomials.databus_id = Polynomial(MAX_DATABUS_SIZE, proving_key.circuit_size);
}
const size_t max_tables_size =
std::min(static_cast<size_t>(MAX_LOOKUP_TABLES_SIZE), dyadic_circuit_size - 1);
Expand Down