feat: Don't store every block number in block indices DB#10658
Merged
PhilWindle merged 16 commits intomasterfrom Dec 17, 2024
Merged
feat: Don't store every block number in block indices DB#10658PhilWindle merged 16 commits intomasterfrom
PhilWindle merged 16 commits intomasterfrom
Conversation
alexghr
approved these changes
Dec 12, 2024
Comment on lines
+135
to
+136
| // Size must be 2 here, if larger, this is an error | ||
| if (blockNumbers.size() != 2) { |
Contributor
There was a problem hiding this comment.
WDYT of changing this to explicit interval_start, interval_end member variables?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The block indices DB is what enables clients to query the block number for a given index. Where there were blocks of zero size (so multiple block numbers against an index) it was storing every block number against that index. This could result in an unbounded values size in the DB. We now just store the block range in this scenario.