refactor: remove get outgoing notes from pxe#10481
Closed
sklppy88 wants to merge 3 commits intoek/refactor/pxe-cleanup/consolidate-contract-functionsfrom
Closed
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 7, 2024
sklppy88
force-pushed
the
ek/refactor/pxe-cleanup/consolidate-contract-functions
branch
from
68dae49 to
7927bf4
Compare
sklppy88
force-pushed
the
ek/refactor/pxe-cleanup/consolidate-contract-functions
branch
from
7927bf4 to
f6540a1
Compare
sklppy88
force-pushed
the
ek/refactor/pxe-cleanup/remove-get-outgoing-notes-from-interface
branch
from
02e0cf0 to
e7dbfc8
Compare
sklppy88
force-pushed
the
ek/refactor/pxe-cleanup/consolidate-contract-functions
branch
from
f6540a1 to
29ca400
Compare
sklppy88
force-pushed
the
ek/refactor/pxe-cleanup/remove-get-outgoing-notes-from-interface
branch
from
e7dbfc8 to
a0cd02c
Compare
added 2 commits
December 8, 2024 20:24
sklppy88
force-pushed
the
ek/refactor/pxe-cleanup/consolidate-contract-functions
branch
from
29ca400 to
5e6660f
Compare
sklppy88
force-pushed
the
ek/refactor/pxe-cleanup/remove-get-outgoing-notes-from-interface
branch
from
a0cd02c to
98973ff
Compare
Contributor
|
Possibly covered here: #10486 |
Contributor
Author
This only covers the PXE interface, but yes happy to defer this to your PR that does the whole cleanup. Didn't realize you'd nuke it all so fast 💪🫡 |
sklppy88
force-pushed
the
ek/refactor/pxe-cleanup/consolidate-contract-functions
branch
from
5e6660f to
1ec02c7
Compare
Contributor
Author
|
Closed as completed by #10486 |
sklppy88
deleted the
ek/refactor/pxe-cleanup/remove-get-outgoing-notes-from-interface
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simply removes adding outgoing notes from the pxe interfaces. It does not touch anything behind the scenes.