Skip to content

fix: max_note_len computation #10438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nventuro merged 3 commits into from
Jan 9, 2025
Merged

fix: max_note_len computation #10438

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec9fad2
Fix max_note_len computation
nventuro Dec 5, 2024
933643e
Fix format
nventuro Dec 6, 2024
5883dfe
Merge branch 'master' into nv/note-len
nventuro Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion noir-projects/aztec-nr/aztec/src/macros/mod.nr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ comptime fn generate_compute_note_hash_and_optionally_a_nullifier() -> Quoted {
max_note_length = notes.fold(
0,
|acc, (_, (_, len, _, _)): (Type, (StructDefinition, u32, Field, [(Quoted, u32, bool)]))| {
acc + len
if len > acc { len } else { acc }
},
);

Expand Down