Skip to content

chore(network_test.sh): work around 143 by disabling stern #10436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ludamad merged 3 commits into from
Dec 6, 2024
Merged

chore(network_test.sh): work around 143 by disabling stern #10436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2fe8be6
chore(network_test.sh): work around 143 by disabling stern
ludamad Dec 5, 2024
96cf17a
Update network_test.sh
ludamad Dec 5, 2024
5db2900
fix: tolerate more missed slots
just-mitch Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions yarn-project/end-to-end/scripts/network_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,13 @@ if [ "$FRESH_INSTALL" = "true" ]; then
kubectl delete namespace "$NAMESPACE" --ignore-not-found=true --wait=true --now --timeout=10m
fi

STERN_PID=""
# STERN_PID=""
function copy_stern_to_log() {
ulimit -n 4096
stern spartan -n $NAMESPACE > $SCRIPT_DIR/network-test.log &
STERN_PID=$!
# TODO(AD) we need to figure out a less resource intensive solution than stern
# ulimit -n 4096
# stern spartan -n $NAMESPACE > $SCRIPT_DIR/network-test.log &
echo "disabled until less resource intensive solution than stern implemented" > $SCRIPT_DIR/network-test.log &
# STERN_PID=$!
}

function show_status_until_pxe_ready() {
Expand Down Expand Up @@ -113,7 +115,7 @@ show_status_until_pxe_ready &

function cleanup() {
# kill everything in our process group except our process
trap - SIGTERM && kill -9 $(pgrep -g $$ | grep -v $$) $(jobs -p) $STERN_PID &>/dev/null || true
trap - SIGTERM && kill -9 $(pgrep -g $$ | grep -v $$) $(jobs -p) &>/dev/null || true

if [ "$CLEANUP_CLUSTER" = "true" ]; then
kind delete cluster || true
Expand Down
4 changes: 2 additions & 2 deletions yarn-project/end-to-end/src/spartan/gating-passive.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ describe('a test that passively observes the network in the presence of network

const ETHEREUM_HOST = `http://127.0.0.1:${HOST_ETHEREUM_PORT}`;
const PXE_URL = `http://127.0.0.1:${HOST_PXE_PORT}`;
// 50% is the max that we expect to miss
const MAX_MISSED_SLOT_PERCENT = 0.5;
// 60% is the max that we expect to miss
const MAX_MISSED_SLOT_PERCENT = 0.6;

afterAll(async () => {
await runAlertCheck(config, qosAlerts, debugLogger);
Expand Down