-
Notifications
You must be signed in to change notification settings - Fork 614
chore: values for sepolia deployment #10362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 9 commits
c33c122
d9cab7b
d049c0e
02fcc11
6141a50
97d1248
c5e0e7c
9633ab9
b9dc642
9cc7cc9
fe15b83
9216a74
44c375c
cb9f57e
37d3d38
1eca57d
6e08c18
afefb5f
3717fb1
dc983f9
bf04092
6ab38e3
ca4e910
5debe14
e3b8a7d
281ce7e
be47200
21bce8c
d72d954
2be454b
49ee379
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -322,4 +322,4 @@ | |
| "flagWords": [ | ||
| "anonymous" | ||
| ] | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,8 +36,8 @@ spec: | |
| cat /shared/config/service-addresses | ||
| echo "Awaiting ethereum node at ${ETHEREUM_HOST}" | ||
| until curl -s -X POST -H 'Content-Type: application/json' \ | ||
| -d '{"jsonrpc":"2.0","method":"web3_clientVersion","params":[],"id":67}' \ | ||
| ${ETHEREUM_HOST} | grep -q reth; do | ||
| -d '{"jsonrpc":"2.0","method":"eth_chainId","params":[],"id":67}' \ | ||
| ${ETHEREUM_HOST} | grep 0x; do | ||
| echo "Waiting for Ethereum node ${ETHEREUM_HOST}..." | ||
| sleep 5 | ||
| done | ||
|
|
@@ -99,7 +99,7 @@ spec: | |
| source /shared/p2p/p2p-addresses && \ | ||
| source /shared/config/service-addresses && \ | ||
| env && \ | ||
| node --no-warnings /usr/src/yarn-project/aztec/dest/bin/index.js start --node --archiver --sequencer --pxe | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why drop the PXE?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. wasn't doing anything right? I believe it was only used for the
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hm yes, but I think this now conflicts with It is convenient in that case because when "dynamic boot node" is enabled, the validators use each other to bootstrap, so they use the PXE service, which is connected to the boot node if the network is public, and the validator service otherwise. So I think the answer is to update the Could/should just be a separate issue though. |
||
| node --no-warnings /usr/src/yarn-project/aztec/dest/bin/index.js start --node --archiver --sequencer | ||
| startupProbe: | ||
| httpGet: | ||
| path: /status | ||
|
|
@@ -154,6 +154,8 @@ spec: | |
| value: "{{ .Values.bootNode.sequencer.minTxsPerBlock }}" | ||
| - name: VALIDATOR_PRIVATE_KEY | ||
| value: "0xac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80" | ||
| - name: SEQ_PUBLISHER_PRIVATE_KEY | ||
| value: "{{ .Values.bootNode.seqPublisherPrivateKey }}" | ||
| - name: OTEL_RESOURCE_ATTRIBUTES | ||
| value: service.name={{ .Release.Name }},service.namespace={{ .Release.Namespace }},service.version={{ .Chart.AppVersion }},environment={{ .Values.environment | default "production" }} | ||
| - name: PROVER_REAL_PROOFS | ||
|
|
@@ -168,6 +170,14 @@ spec: | |
| value: "{{ .Values.aztec.epochDuration }}" | ||
| - name: AZTEC_EPOCH_PROOF_CLAIM_WINDOW_IN_L2_SLOTS | ||
| value: "{{ .Values.aztec.epochProofClaimWindow }}" | ||
| - name: ARCHIVER_POLLING_INTERVAL_MS | ||
| value: {{ .Values.bootNode.archiverPollingInterval | quote }} | ||
| - name: ARCHIVER_VIEM_POLLING_INTERVAL_MS | ||
| value: {{ .Values.bootNode.archiverViemPollingInterval | quote }} | ||
| - name: L1_READER_VIEM_POLLING_INTERVAL_MS | ||
| value: {{ .Values.bootNode.archiverViemPollingInterval | quote }} | ||
| - name: SEQ_VIEM_POLLING_INTERVAL_MS | ||
| value: {{ .Values.bootNode.viemPollingInterval | quote }} | ||
| - name: PEER_ID_PRIVATE_KEY | ||
| value: "{{ .Values.bootNode.peerIdPrivateKey }}" | ||
| ports: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| {{- if not .Values.network.disableEthNode }} | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. instead of adding a new flag, could this be replaced by checking if .Values.ethereum.externalHost is set? If we wanted a flag, we could create a helper based off checking that value? |
||
| apiVersion: apps/v1 | ||
| kind: Deployment | ||
| metadata: | ||
|
|
@@ -135,4 +136,5 @@ spec: | |
| requests: | ||
| storage: {{ .Values.ethereum.storage }} | ||
| {{- end }} | ||
| --- | ||
| --- | ||
| {{ end }} | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| telemetry: | ||
| enabled: true | ||
| otelCollectorEndpoint: http://metrics-opentelemetry-collector.metrics:4318 | ||
|
|
||
| network: | ||
| setupL2Contracts: false | ||
| disableEthNode: true | ||
| public: false | ||
|
|
||
| ethereum: | ||
| externalHost: "https://sepolia.infura.io/v3/${INFURA_API_KEY}" | ||
| chainId: "11155111" | ||
|
|
||
| validator: | ||
| replicas: 3 | ||
| validatorKeys: ${VALIDATOR_KEYS} | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How do these get set? I didn't think you could pull from env like this in a values file. |
||
| validatorAddresses: ${VALIDATOR_ADDRESSES} | ||
| validator: | ||
| disabled: false | ||
|
|
||
| bootNode: | ||
| seqPublisherPrivateKey: ${SEQ_PUBLISHER_PRIVATE_KEY} | ||
| validator: | ||
| disabled: true | ||
|
|
||
| proverNode: | ||
| proverPublisherPrivateKey: ${PROVER_PUBLISHER_PRIVATE_KEY} | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,7 +36,15 @@ if [ "$NUM_VALIDATORS" -eq 1 ]; then | |
| echo "Running single validator directly" | ||
| eval "${CMD[0]}" | ||
| else | ||
| echo "Running $NUM_VALIDATORS validators interleaved" | ||
| # Execute the run_interleaved.sh script with the commands | ||
| "$(git rev-parse --show-toplevel)/scripts/run_interleaved.sh" "${CMD[@]}" | ||
| echo "Running $NUM_VALIDATORS validators sequentially, interleaved" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. supernit: no longer sequentially |
||
| FIRST_PORT=8081 | ||
|
|
||
| # check if we're running against anvil | ||
| if curl -s -H "Content-Type: application/json" -X POST --data '{"method":"web3_clientVersion","params":[],"id":49,"jsonrpc":"2.0"}' $ETHEREUM_HOST | jq .result | grep -q anvil; then | ||
| "$(git rev-parse --show-toplevel)/scripts/run_interleaved.sh" "${CMD[@]}" | ||
| else | ||
| # Use run_interleaved with a wait condition | ||
| WAIT_CONDITION="curl -s http://127.0.0.1:$FIRST_PORT/status >/dev/null" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. was this wait condition added to prevent them being added with the same key? #10327 this pr pre adds the validators at contract deployment time so may invalidate the need for this work around |
||
| "$(git rev-parse --show-toplevel)/scripts/run_interleaved.sh" -w "$WAIT_CONDITION" "${CMD[@]}" | ||
| fi | ||
| fi | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about this one. Hope you didn't lose much time.