feat: Use UltraRollupHonk in rollup#10342
Merged
lucasxia01 merged 134 commits intomasterfrom Dec 24, 2024
Merged
Conversation
lucasxia01
commented
Dec 23, 2024
barretenberg/cpp/src/barretenberg/commitment_schemes/ipa/ipa.hpp
Outdated
Show resolved
Hide resolved
lucasxia01
commented
Dec 23, 2024
barretenberg/cpp/src/barretenberg/commitment_schemes/ipa/ipa.hpp
Outdated
Show resolved
Hide resolved
lucasxia01
commented
Dec 23, 2024
barretenberg/cpp/src/barretenberg/dsl/acir_format/acir_format.cpp
Outdated
Show resolved
Hide resolved
lucasxia01
commented
Dec 23, 2024
| } | ||
| // Accumulate the claims | ||
| if (nested_ipa_claims.size() == 2) { | ||
| // init Grumpkin CRS |
lucasxia01
commented
Dec 23, 2024
| @@ -634,9 +634,13 @@ void handle_blackbox_func_call(Program::Opcode::BlackBoxFuncCall const& arg, | |||
| // TODO(https://github.com/AztecProtocol/barretenberg/issues/1074): Eventually arg.proof_type will | |||
Contributor
Author
There was a problem hiding this comment.
see if we can delete this in a followup
lucasxia01
commented
Dec 23, 2024
barretenberg/cpp/src/barretenberg/dsl/acir_format/honk_recursion_constraint.cpp
Outdated
Show resolved
Hide resolved
lucasxia01
commented
Dec 23, 2024
barretenberg/cpp/src/barretenberg/stdlib/honk_verifier/ultra_recursive_verifier.cpp
Show resolved
Hide resolved
lucasxia01
commented
Dec 23, 2024
barretenberg/cpp/src/barretenberg/stdlib/honk_verifier/ultra_recursive_verifier.test.cpp
Show resolved
Hide resolved
ledwards2225
approved these changes
Dec 23, 2024
Contributor
There was a problem hiding this comment.
We discussed on a call. LG, we discussed the following general updates:
- Consider how to improve debugging of self_reduce() issue
- Organize mock IPA proof construction (etc) into methods
- Comments wherever possible
- Possibly simplify regenerate verify proof inputs scripts
- Think about path for future removal of honk_recursion as integer
lucasxia01
commented
Dec 23, 2024
lucasxia01
commented
Dec 23, 2024
This was referenced Jan 2, 2025
Merged
codygunton
reviewed
Jan 24, 2025
|
|
||
| // output the vk | ||
| typename Flavor::VerificationKey vk(prover.proving_key->proving_key); | ||
| debug(vk.to_field_elements()); |
Contributor
There was a problem hiding this comment.
Please be more careful to remove these things--I just had to track this down
Contributor
Author
There was a problem hiding this comment.
my fault, didn't realize NDEBUG was off for most builds, and I recently made a change such that debug() prints when NDEBUG was off. I had assumed it was only off in debugging builds. I reverted it here: #11498.
codygunton
reviewed
Jan 24, 2025
| vinfo("binary proof written to: ", proofPath); | ||
|
|
||
| // Write the proof as fields | ||
| info("proof: ", proof); |
Contributor
Author
There was a problem hiding this comment.
oops, this got lost in the commit. My fault
codygunton
reviewed
Jan 24, 2025
|
|
||
| // Write the vk as fields | ||
| std::vector<bb::fr> vk_data = vk.to_field_elements(); | ||
| debug("vk: ", vk_data); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses UltraRollupFlavor and UltraRecursiveRollupFlavor in the rollup.
Modifies UltraRecursiveVerifier tests to also test rollup flavors.
Adds new test program,
verify_rollup_honk_proof, and new flows for test program.