[WIP] feat: _exceptional halts_ in AVM simulator (like div/0) consume all remaining allocated gas#10259
Closed
[WIP] feat: _exceptional halts_ in AVM simulator (like div/0) consume all remaining allocated gas#10259
Conversation
dbanks12
changed the title
fcarreiro
reviewed
Nov 27, 2024
Contributor
fcarreiro
left a comment
fcarreiro
left a comment
There was a problem hiding this comment.
LG but is this in sync with witgen?
Contributor
Author
... nope! Going to figure out how to do the witgen side of it before we merge. Will flag WIP |
dbanks12
changed the title
Contributor
|
I wouldn't be surprised if you need to disable some constraint (or modify it to accomodate the jump in gas unrelated to the cost of the opcode) |
Contributor
Author
|
Replaced by #10731 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.