test: Ephemeral tree hashPreimage#10232
Merged
dbanks12 merged 2 commits intodb/insert-private-nullifiers-avmfrom Nov 27, 2024
Merged
test: Ephemeral tree hashPreimage#10232dbanks12 merged 2 commits intodb/insert-private-nullifiers-avmfrom
dbanks12 merged 2 commits intodb/insert-private-nullifiers-avmfrom
Conversation
dbanks12
approved these changes
Nov 27, 2024
Contributor
|
Approved, but it looks like it's failing 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The benchmark run actually also doubles as a useful test vector since it updates a "pre-filled" leaf.
This test is also useful in that it shows that we don't need the condition on the
hashPreimage. The only time thegetKey() === 0ncondition is used in the worldstate (which wasnt right in the ephemeral trees anyways) is when we are using the forced null inclusion on public data tree updates - which the avm trees handle separately (and isn't long for this world anyways).tl;dr
Old version
New Version