feat: using current gas prices in cli-wallet by LHerskind · Pull Request #10105 · AztecProtocol/aztec-packages

LHerskind · 2024-11-21T14:12:18Z

Fixes #9722. Updating the cli wallet to be pulling the current gas prices instead of just using the default.

Deletes the default on GasFees since it will always be incorrect.

LHerskind · 2024-11-21T14:12:34Z

feat: add total mana used to header #9868
feat: using current gas prices in cli-wallet #10105 👈 (View in Graphite)
feat: integrate fee into rollup #10176
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

just-mitch · 2024-11-25T13:30:33Z

yarn-project/cli-wallet/src/utils/options/fees.ts

+    return acc;
+  }, {} as Record<string, number>);
+
+  const expected = ['da', 'l2'];


Are you sure we want to expect DA gas here?

Probably not, were mainly for completeness.

This will probably shake out as a single issue against aztec.js like "chore: remove mention of DA gas/fees from user facing code"

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.65.1</summary> ## [0.65.1](aztec-package-v0.65.0...aztec-package-v0.65.1) (2024-11-27) ### Miscellaneous * Delete old serialization methods ([#9951](#9951)) ([10d3f6f](10d3f6f)) </details> <details><summary>barretenberg.js: 0.65.1</summary> ## [0.65.1](barretenberg.js-v0.65.0...barretenberg.js-v0.65.1) (2024-11-27) ### Features * Speed up transaction execution ([#10172](#10172)) ([da265b6](da265b6)) ### Bug Fixes * Add pako as a dependency in bb.js ([#10186](#10186)) ([b773c14](b773c14)) </details> <details><summary>aztec-packages: 0.65.1</summary> ## [0.65.1](aztec-packages-v0.65.0...aztec-packages-v0.65.1) (2024-11-27) ### Features * Add total mana used to header ([#9868](#9868)) ([2478d19](2478d19)) * Assert metrics in network tests ([#10215](#10215)) ([9380c0f](9380c0f)) * Avm inserts nullifiers from private ([#10129](#10129)) ([3fc0c7c](3fc0c7c)) * Burn congestion fee ([#10231](#10231)) ([20a33f2](20a33f2)) * Configure world state block history ([#10216](#10216)) ([01eb392](01eb392)) * Integrate fee into rollup ([#10176](#10176)) ([12744d6](12744d6)) * Speed up transaction execution ([#10172](#10172)) ([da265b6](da265b6)) * Using current gas prices in cli-wallet ([#10105](#10105)) ([15ffeea](15ffeea)) ### Bug Fixes * Add pako as a dependency in bb.js ([#10186](#10186)) ([b773c14](b773c14)) * **avm:** Execution test ordering ([#10226](#10226)) ([49b4a6c](49b4a6c)) * Deploy preview master ([#10227](#10227)) ([321a175](321a175)) * Use current base fee for public fee payment ([#10230](#10230)) ([f081d80](f081d80)) ### Miscellaneous * Add traces and histograms to avm simulator ([#10233](#10233)) ([e83726d](e83726d)), closes [#10146](#10146) * Avm-proving and avm-integration tests do not require simulator to export function with jest mocks ([#10228](#10228)) ([f28fcdb](f28fcdb)) * **avm:** Handle parsing error ([#10203](#10203)) ([3c623fc](3c623fc)), closes [#9770](#9770) * **avm:** Zero initialization in avm public inputs and execution test fixes ([#10238](#10238)) ([0c7c4c9](0c7c4c9)) * Bump timeout for after-hook for data store test again ([#10240](#10240)) ([52047f0](52047f0)) * CIVC VK ([#10223](#10223)) ([089c34c](089c34c)) * Declare global types ([#10206](#10206)) ([7b2e343](7b2e343)) * Delete old serialization methods ([#9951](#9951)) ([10d3f6f](10d3f6f)) * Fix migration notes ([#10252](#10252)) ([05bdcd5](05bdcd5)) * Pull out some sync changes ([#10245](#10245)) ([1bfc15e](1bfc15e)) * Remove docs from sync ([#10241](#10241)) ([eeea0aa](eeea0aa)) * Replace relative paths to noir-protocol-circuits ([e7690ca](e7690ca)) </details> <details><summary>barretenberg: 0.65.1</summary> ## [0.65.1](barretenberg-v0.65.0...barretenberg-v0.65.1) (2024-11-27) ### Features * Add total mana used to header ([#9868](#9868)) ([2478d19](2478d19)) * Configure world state block history ([#10216](#10216)) ([01eb392](01eb392)) * Speed up transaction execution ([#10172](#10172)) ([da265b6](da265b6)) ### Bug Fixes * **avm:** Execution test ordering ([#10226](#10226)) ([49b4a6c](49b4a6c)) ### Miscellaneous * **avm:** Handle parsing error ([#10203](#10203)) ([3c623fc](3c623fc)), closes [#9770](#9770) * **avm:** Zero initialization in avm public inputs and execution test fixes ([#10238](#10238)) ([0c7c4c9](0c7c4c9)) * CIVC VK ([#10223](#10223)) ([089c34c](089c34c)) * Pull out some sync changes ([#10245](#10245)) ([1bfc15e](1bfc15e)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.65.1</summary> ## [0.65.1](AztecProtocol/aztec-packages@aztec-package-v0.65.0...aztec-package-v0.65.1) (2024-11-27) ### Miscellaneous * Delete old serialization methods ([#9951](AztecProtocol/aztec-packages#9951)) ([10d3f6f](AztecProtocol/aztec-packages@10d3f6f)) </details> <details><summary>barretenberg.js: 0.65.1</summary> ## [0.65.1](AztecProtocol/aztec-packages@barretenberg.js-v0.65.0...barretenberg.js-v0.65.1) (2024-11-27) ### Features * Speed up transaction execution ([#10172](AztecProtocol/aztec-packages#10172)) ([da265b6](AztecProtocol/aztec-packages@da265b6)) ### Bug Fixes * Add pako as a dependency in bb.js ([#10186](AztecProtocol/aztec-packages#10186)) ([b773c14](AztecProtocol/aztec-packages@b773c14)) </details> <details><summary>aztec-packages: 0.65.1</summary> ## [0.65.1](AztecProtocol/aztec-packages@aztec-packages-v0.65.0...aztec-packages-v0.65.1) (2024-11-27) ### Features * Add total mana used to header ([#9868](AztecProtocol/aztec-packages#9868)) ([2478d19](AztecProtocol/aztec-packages@2478d19)) * Assert metrics in network tests ([#10215](AztecProtocol/aztec-packages#10215)) ([9380c0f](AztecProtocol/aztec-packages@9380c0f)) * Avm inserts nullifiers from private ([#10129](AztecProtocol/aztec-packages#10129)) ([3fc0c7c](AztecProtocol/aztec-packages@3fc0c7c)) * Burn congestion fee ([#10231](AztecProtocol/aztec-packages#10231)) ([20a33f2](AztecProtocol/aztec-packages@20a33f2)) * Configure world state block history ([#10216](AztecProtocol/aztec-packages#10216)) ([01eb392](AztecProtocol/aztec-packages@01eb392)) * Integrate fee into rollup ([#10176](AztecProtocol/aztec-packages#10176)) ([12744d6](AztecProtocol/aztec-packages@12744d6)) * Speed up transaction execution ([#10172](AztecProtocol/aztec-packages#10172)) ([da265b6](AztecProtocol/aztec-packages@da265b6)) * Using current gas prices in cli-wallet ([#10105](AztecProtocol/aztec-packages#10105)) ([15ffeea](AztecProtocol/aztec-packages@15ffeea)) ### Bug Fixes * Add pako as a dependency in bb.js ([#10186](AztecProtocol/aztec-packages#10186)) ([b773c14](AztecProtocol/aztec-packages@b773c14)) * **avm:** Execution test ordering ([#10226](AztecProtocol/aztec-packages#10226)) ([49b4a6c](AztecProtocol/aztec-packages@49b4a6c)) * Deploy preview master ([#10227](AztecProtocol/aztec-packages#10227)) ([321a175](AztecProtocol/aztec-packages@321a175)) * Use current base fee for public fee payment ([#10230](AztecProtocol/aztec-packages#10230)) ([f081d80](AztecProtocol/aztec-packages@f081d80)) ### Miscellaneous * Add traces and histograms to avm simulator ([#10233](AztecProtocol/aztec-packages#10233)) ([e83726d](AztecProtocol/aztec-packages@e83726d)), closes [#10146](AztecProtocol/aztec-packages#10146) * Avm-proving and avm-integration tests do not require simulator to export function with jest mocks ([#10228](AztecProtocol/aztec-packages#10228)) ([f28fcdb](AztecProtocol/aztec-packages@f28fcdb)) * **avm:** Handle parsing error ([#10203](AztecProtocol/aztec-packages#10203)) ([3c623fc](AztecProtocol/aztec-packages@3c623fc)), closes [#9770](AztecProtocol/aztec-packages#9770) * **avm:** Zero initialization in avm public inputs and execution test fixes ([#10238](AztecProtocol/aztec-packages#10238)) ([0c7c4c9](AztecProtocol/aztec-packages@0c7c4c9)) * Bump timeout for after-hook for data store test again ([#10240](AztecProtocol/aztec-packages#10240)) ([52047f0](AztecProtocol/aztec-packages@52047f0)) * CIVC VK ([#10223](AztecProtocol/aztec-packages#10223)) ([089c34c](AztecProtocol/aztec-packages@089c34c)) * Declare global types ([#10206](AztecProtocol/aztec-packages#10206)) ([7b2e343](AztecProtocol/aztec-packages@7b2e343)) * Delete old serialization methods ([#9951](AztecProtocol/aztec-packages#9951)) ([10d3f6f](AztecProtocol/aztec-packages@10d3f6f)) * Fix migration notes ([#10252](AztecProtocol/aztec-packages#10252)) ([05bdcd5](AztecProtocol/aztec-packages@05bdcd5)) * Pull out some sync changes ([#10245](AztecProtocol/aztec-packages#10245)) ([1bfc15e](AztecProtocol/aztec-packages@1bfc15e)) * Remove docs from sync ([#10241](AztecProtocol/aztec-packages#10241)) ([eeea0aa](AztecProtocol/aztec-packages@eeea0aa)) * Replace relative paths to noir-protocol-circuits ([e7690ca](AztecProtocol/aztec-packages@e7690ca)) </details> <details><summary>barretenberg: 0.65.1</summary> ## [0.65.1](AztecProtocol/aztec-packages@barretenberg-v0.65.0...barretenberg-v0.65.1) (2024-11-27) ### Features * Add total mana used to header ([#9868](AztecProtocol/aztec-packages#9868)) ([2478d19](AztecProtocol/aztec-packages@2478d19)) * Configure world state block history ([#10216](AztecProtocol/aztec-packages#10216)) ([01eb392](AztecProtocol/aztec-packages@01eb392)) * Speed up transaction execution ([#10172](AztecProtocol/aztec-packages#10172)) ([da265b6](AztecProtocol/aztec-packages@da265b6)) ### Bug Fixes * **avm:** Execution test ordering ([#10226](AztecProtocol/aztec-packages#10226)) ([49b4a6c](AztecProtocol/aztec-packages@49b4a6c)) ### Miscellaneous * **avm:** Handle parsing error ([#10203](AztecProtocol/aztec-packages#10203)) ([3c623fc](AztecProtocol/aztec-packages@3c623fc)), closes [#9770](AztecProtocol/aztec-packages#9770) * **avm:** Zero initialization in avm public inputs and execution test fixes ([#10238](AztecProtocol/aztec-packages#10238)) ([0c7c4c9](AztecProtocol/aztec-packages@0c7c4c9)) * CIVC VK ([#10223](AztecProtocol/aztec-packages#10223)) ([089c34c](AztecProtocol/aztec-packages@089c34c)) * Pull out some sync changes ([#10245](AztecProtocol/aztec-packages#10245)) ([1bfc15e](AztecProtocol/aztec-packages@1bfc15e)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Deletes default fee in gas settings, and makes `maxFeePerGas` required for initializing a `GasSettings` instance. Built on top of #10105.

This was referenced Nov 21, 2024

feat: multiplier oracle #9902

Merged

feat: initial gas oracle #9952

Merged

feat: compute base-fee on l1 #9986

Merged

LHerskind mentioned this pull request Nov 21, 2024

feat: integrate base fee computation into rollup #10076

Merged

LHerskind changed the title ~~feat: reducing usage of default gas settings~~ feat: using current gas prices in cli-wallet Nov 21, 2024

LHerskind linked an issue Nov 21, 2024 that may be closed by this pull request

feat: update CLI to work with new fee mechanism #9722

Closed

LHerskind marked this pull request as ready for review November 21, 2024 14:57

LHerskind force-pushed the lh/9962-base-fee-in-rollup-contract branch from b6096f8 to cd042a7 Compare November 21, 2024 16:21

LHerskind force-pushed the lh/9722 branch from 5bd39ed to edc701f Compare November 21, 2024 16:21

LHerskind force-pushed the lh/9962-base-fee-in-rollup-contract branch from cd042a7 to 6f63256 Compare November 21, 2024 16:48

LHerskind force-pushed the lh/9722 branch from edc701f to 5251ac4 Compare November 21, 2024 16:48

LHerskind force-pushed the lh/9962-base-fee-in-rollup-contract branch from 6f63256 to 62cdd66 Compare November 21, 2024 17:02

LHerskind force-pushed the lh/9722 branch from 5251ac4 to eb2c07e Compare November 21, 2024 17:02

LHerskind force-pushed the lh/9962-base-fee-in-rollup-contract branch 2 times, most recently from 96ccafe to c87ce1c Compare November 21, 2024 22:19

LHerskind force-pushed the lh/9722 branch from eb2c07e to 2062468 Compare November 21, 2024 22:19

LHerskind requested review from Maddiaa0 and just-mitch November 22, 2024 11:44

LHerskind force-pushed the lh/9962-base-fee-in-rollup-contract branch 2 times, most recently from 6bca6ff to dd30fb6 Compare November 22, 2024 22:27

LHerskind force-pushed the lh/9722 branch from 2062468 to e6bdd79 Compare November 22, 2024 22:27

Base automatically changed from lh/9962-base-fee-in-rollup-contract to master November 22, 2024 23:24

LHerskind force-pushed the lh/9722 branch 2 times, most recently from cc100bd to ac828f2 Compare November 25, 2024 12:59

LHerskind changed the base branch from master to lh/9962-base-fee-in-rollup-contract November 25, 2024 12:59

LHerskind mentioned this pull request Nov 25, 2024

feat: integrate fee into rollup #10176

Merged

just-mitch reviewed Nov 25, 2024

View reviewed changes

just-mitch approved these changes Nov 25, 2024

View reviewed changes

LHerskind force-pushed the lh/9962-base-fee-in-rollup-contract branch from 67f6a41 to 798763a Compare November 25, 2024 16:49

LHerskind force-pushed the lh/9722 branch from ac828f2 to 5a7c3fa Compare November 25, 2024 16:49

LHerskind mentioned this pull request Nov 25, 2024

feat: add total mana used to header #9868

Merged

LHerskind force-pushed the lh/9962-base-fee-in-rollup-contract branch from 798763a to 479ca01 Compare November 25, 2024 23:52

LHerskind force-pushed the lh/9722 branch from 5a7c3fa to 412c098 Compare November 25, 2024 23:52

LHerskind marked this pull request as draft November 26, 2024 07:57

LHerskind force-pushed the lh/9962-base-fee-in-rollup-contract branch from 479ca01 to 5cad510 Compare November 26, 2024 07:57

LHerskind force-pushed the lh/9722 branch from 412c098 to 234f341 Compare November 26, 2024 07:57

LHerskind force-pushed the lh/9962-base-fee-in-rollup-contract branch from 5cad510 to ed3e2be Compare November 26, 2024 08:26

LHerskind force-pushed the lh/9722 branch from 234f341 to 080c74e Compare November 26, 2024 08:26

LHerskind force-pushed the lh/9962-base-fee-in-rollup-contract branch from ed3e2be to 86d2185 Compare November 26, 2024 09:30

LHerskind force-pushed the lh/9722 branch from 080c74e to efbd549 Compare November 26, 2024 09:31

LHerskind marked this pull request as ready for review November 26, 2024 11:39

LHerskind added e2e-all and removed network-all labels Nov 26, 2024

LHerskind force-pushed the lh/9962-base-fee-in-rollup-contract branch from 86d2185 to e5a2750 Compare November 26, 2024 15:40

LHerskind force-pushed the lh/9722 branch from efbd549 to 707f664 Compare November 26, 2024 15:40

Base automatically changed from lh/9962-base-fee-in-rollup-contract to master November 26, 2024 19:00

feat: reducing usage of default gas settings

8c53565

LHerskind force-pushed the lh/9722 branch from 707f664 to 8c53565 Compare November 26, 2024 19:41

spalladino mentioned this pull request Nov 26, 2024

chore: Remove default gas settings #10163

Merged

LHerskind merged commit 15ffeea into master Nov 26, 2024

LHerskind deleted the lh/9722 branch November 26, 2024 21:44

AztecBot mentioned this pull request Nov 26, 2024

chore(master): Release 0.65.1 #10219

Merged

spalladino added a commit that referenced this pull request Nov 28, 2024

chore: Remove default gas settings (#10163)

c9a4d88

Deletes default fee in gas settings, and makes `maxFeePerGas` required for initializing a `GasSettings` instance. Built on top of #10105.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: using current gas prices in cli-wallet#10105

feat: using current gas prices in cli-wallet#10105
LHerskind merged 1 commit intomasterfrom
lh/9722

LHerskind commented Nov 21, 2024 •

edited

Loading

Uh oh!

LHerskind commented Nov 21, 2024 •

edited

Loading

Uh oh!

just-mitch Nov 25, 2024

Uh oh!

LHerskind Nov 25, 2024

Uh oh!

just-mitch Nov 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

LHerskind commented Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LHerskind commented Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

just-mitch Nov 25, 2024

Choose a reason for hiding this comment

Uh oh!

LHerskind Nov 25, 2024

Choose a reason for hiding this comment

Uh oh!

just-mitch Nov 25, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

LHerskind commented Nov 21, 2024 •

edited

Loading

LHerskind commented Nov 21, 2024 •

edited

Loading