feat: UltraRollupRecursiveFlavor by lucasxia01 · Pull Request #10088 · AztecProtocol/aztec-packages

lucasxia01 · 2024-11-21T00:05:12Z

Creates new recursive flavor. The recursive verifier with this flavor will extract the IPA claim from the public inputs and return it as part of its output. Modifies the ClientTubeBase test to use this new flavor.

…ursive-flavor

lucasxia01 · 2024-11-22T21:33:34Z

barretenberg/cpp/src/barretenberg/stdlib/honk_verifier/ultra_recursive_verifier.cpp

+            ipa_claim.commitment = {
+                verification_key->public_inputs[verification_key->verification_key->ipa_claim_public_input_indices[4]],
+                verification_key->public_inputs[verification_key->verification_key->ipa_claim_public_input_indices[5]],
+                false // WORKTODO: make this a witness?


maybe this can stay as a constant?

lucasxia01 · 2024-11-22T21:40:51Z

barretenberg/cpp/src/barretenberg/stdlib_circuit_builders/ultra_circuit_builder.hpp

@@ -381,23 +381,20 @@ class UltraCircuitBuilder_ : public CircuitBuilderBase<typename ExecutionTrace_:
        this->is_recursive_circuit = recursive;


random cleanup in this file

lucasxia01 · 2024-11-22T21:41:21Z

barretenberg/cpp/src/barretenberg/stdlib_circuit_builders/ultra_rollup_recursive_flavor.hpp

@@ -0,0 +1,144 @@
+#pragma once


new recursive flavor - key difference is the IPA bool and indices in the VerificationKey

lucasxia01 · 2024-11-22T21:42:25Z

barretenberg/cpp/src/barretenberg/stdlib_circuit_builders/circuit_simulator.hpp


    [[nodiscard]] bool check_circuit() const { return !_failed; }

+    size_t create_ROM_array([[maybe_unused]] const size_t array_size) { return {}; }


had to add these since cycle group takes in CircuitSimulator now, because its being used in the ultra RecursiveVerifier

codygunton

LGTM

barretenberg/cpp/src/barretenberg/dsl/acir_format/honk_recursion_constraint.cpp

codygunton · 2024-11-25T14:16:17Z

barretenberg/cpp/src/barretenberg/flavor/flavor.hpp


 template <typename T>
-concept HasIPAAccumulatorFlavor = IsAnyOf<T, UltraRollupFlavor>;
+concept HasIPAAccumulatorFlavor = IsAnyOf<T, UltraRollupFlavor, UltraRollupRecursiveFlavor_<UltraCircuitBuilder>>;


Nit: concept name is ungrammatical; if constexpr HasIPAAccumulator<Flavor> vs if constexpr HasIPAAccumulatorFlavor<Flavor>

yeah fair. Was following the style of some of the other flavor names which have Flavor in them, but I can remove this one

barretenberg/cpp/src/barretenberg/stdlib/honk_verifier/ultra_recursive_verifier.cpp

codygunton · 2024-11-25T14:21:03Z

barretenberg/cpp/src/barretenberg/stdlib_circuit_builders/ultra_rollup_recursive_flavor.hpp

+         * @return VerificationKey
+         */
+        static VerificationKey from_witness_indices(CircuitBuilder& builder,
+                                                    const std::span<const uint32_t>& witness_indices)


We've gotten in trouble before passing references to spans--can you just pass by value?

not sure how passing it by value vs by const reference would fix those potential issues.

* master: (106 commits) feat: blobs. (#9302) chore(avm): operands reordering (#10182) feat: UltraRollupRecursiveFlavor (#10088) feat: one liner for nodes to join rough-rhino (#10168) feat!: rename sharedimmutable methods (#10164) chore(master): Release 0.64.0 (#10043) feat: e2e metrics reporting (#9776) chore: fix pool metrics (#9652) chore: Initial draft of testnet-runbook (#10085) feat: Improved data storage metrics (#10020) chore: Remove handling of duplicates from the note hash tree (#10016) fix: add curl to aztec nargo container (#10173) fix: Revert "feat: integrate base fee computation into rollup" (#10166) feat!: rename SharedMutable methods (#10165) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits git subrepo push --branch=master barretenberg feat: sync tags as sender (#10071) feat: integrate base fee computation into rollup (#10076) ...

* master: (64 commits) fix: docker compose aztec up fix (#10197) fix: aztec-nargo curl in the earthfile also (#10199) chore: fix devbox (#10201) chore: misc cleanup (#10194) fix: release l1-contracts (#10095) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits git subrepo push --branch=master barretenberg feat: Origin tags implemented in biggroup (#10002) fix: Revert "feat: blobs. (#9302)" (#10187) feat!: remove SharedImmutable (#10183) fix(bb.js): don't minify bb.js - webpack config (#10170) feat: blobs. (#9302) chore(avm): operands reordering (#10182) feat: UltraRollupRecursiveFlavor (#10088) feat: one liner for nodes to join rough-rhino (#10168) feat!: rename sharedimmutable methods (#10164) chore(master): Release 0.64.0 (#10043) feat: e2e metrics reporting (#9776) ...

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.65.0</summary> ## [0.65.0](aztec-package-v0.64.0...aztec-package-v0.65.0) (2024-11-26) ### Features * **avm:** New public inputs witgen ([#10179](#10179)) ([ac8f13e](ac8f13e)) </details> <details><summary>barretenberg.js: 0.65.0</summary> ## [0.65.0](barretenberg.js-v0.64.0...barretenberg.js-v0.65.0) (2024-11-26) ### Bug Fixes * **bb.js:** Don't minify bb.js - webpack config ([#10170](#10170)) ([6e7fae7](6e7fae7)) </details> <details><summary>aztec-packages: 0.65.0</summary> ## [0.65.0](aztec-packages-v0.64.0...aztec-packages-v0.65.0) (2024-11-26) ### ⚠ BREAKING CHANGES * remove SharedImmutable ([#10183](#10183)) * rename sharedimmutable methods ([#10164](#10164)) ### Features * **avm:** New public inputs witgen ([#10179](#10179)) ([ac8f13e](ac8f13e)) * Blobs. ([#9302](#9302)) ([03b7e0e](03b7e0e)) * One liner for nodes to join rough-rhino ([#10168](#10168)) ([3a425e9](3a425e9)) * Origin tags implemented in biggroup ([#10002](#10002)) ([c8696b1](c8696b1)) * Remove SharedImmutable ([#10183](#10183)) ([a9f3b5f](a9f3b5f)) * Rename sharedimmutable methods ([#10164](#10164)) ([ef7cd86](ef7cd86)) * UltraRollupRecursiveFlavor ([#10088](#10088)) ([4418ef2](4418ef2)) ### Bug Fixes * Aztec-nargo curl in the earthfile also ([#10199](#10199)) ([985a678](985a678)) * **bb.js:** Don't minify bb.js - webpack config ([#10170](#10170)) ([6e7fae7](6e7fae7)) * Docker compose aztec up fix ([#10197](#10197)) ([d7ae959](d7ae959)) * Increase test timeouts ([#10205](#10205)) ([195aa3d](195aa3d)) * Release l1-contracts ([#10095](#10095)) ([29f0d7a](29f0d7a)) * Revert "feat: blobs. ([#9302](#9302))" ([#10187](#10187)) ([a415f65](a415f65)) ### Miscellaneous * Added ref to env variables ([#10193](#10193)) ([b51fc43](b51fc43)) * **avm:** Operands reordering ([#10182](#10182)) ([69bdf4f](69bdf4f)), closes [#10136](#10136) * Fix devbox ([#10201](#10201)) ([323eaee](323eaee)) * Misc cleanup ([#10194](#10194)) ([dd01417](dd01417)) * Reinstate docs-preview, fix doc publish ([#10213](#10213)) ([ed9a0e3](ed9a0e3)) * Replace relative paths to noir-protocol-circuits ([1650446](1650446)) </details> <details><summary>barretenberg: 0.65.0</summary> ## [0.65.0](barretenberg-v0.64.0...barretenberg-v0.65.0) (2024-11-26) ### Features * **avm:** New public inputs witgen ([#10179](#10179)) ([ac8f13e](ac8f13e)) * Origin tags implemented in biggroup ([#10002](#10002)) ([c8696b1](c8696b1)) * UltraRollupRecursiveFlavor ([#10088](#10088)) ([4418ef2](4418ef2)) ### Miscellaneous * **avm:** Operands reordering ([#10182](#10182)) ([69bdf4f](69bdf4f)), closes [#10136](#10136) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

new flavor - ultra rollup recursive

124b188

lucasxia01 self-assigned this Nov 21, 2024

lucasxia01 added 4 commits November 21, 2024 15:45

Merge remote-tracking branch 'origin/master' into lx/ultra-rollup-rec…

5ebabd7

…ursive-flavor

stuff

2662eab

change return type of recursive verifier

8a488a7

fix build

b3e5265

lucasxia01 marked this pull request as ready for review November 21, 2024 21:16

lucasxia01 added 3 commits November 21, 2024 21:17

Merge remote-tracking branch 'origin/master' into lx/ultra-rollup-rec…

64a3105

…ursive-flavor

fix build for all

bc41b7d

extract ipa claim in ultra recursive verifier

907cbbd

lucasxia01 commented Nov 22, 2024

View reviewed changes

codygunton approved these changes Nov 25, 2024

View reviewed changes

lucasxia01 added 2 commits November 25, 2024 15:01

address comments

705a5b4

Merge branch 'master' into lx/ultra-rollup-recursive-flavor

66421c0

lucasxia01 enabled auto-merge (squash) November 25, 2024 15:48

lucasxia01 merged commit 4418ef2 into master Nov 25, 2024

lucasxia01 deleted the lx/ultra-rollup-recursive-flavor branch November 25, 2024 16:28

AztecBot mentioned this pull request Nov 25, 2024

chore(master): Release 0.65.0 #10181

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: UltraRollupRecursiveFlavor#10088

feat: UltraRollupRecursiveFlavor#10088
lucasxia01 merged 10 commits intomasterfrom
lx/ultra-rollup-recursive-flavor

lucasxia01 commented Nov 21, 2024 •

edited

Loading

Uh oh!

lucasxia01 Nov 22, 2024

Uh oh!

lucasxia01 Nov 22, 2024

Uh oh!

lucasxia01 Nov 22, 2024

Uh oh!

lucasxia01 Nov 22, 2024

Uh oh!

codygunton left a comment

Uh oh!

Uh oh!

codygunton Nov 25, 2024

Uh oh!

lucasxia01 Nov 25, 2024 •

edited

Loading

Uh oh!

Uh oh!

codygunton Nov 25, 2024

Uh oh!

lucasxia01 Nov 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -381,23 +381,20 @@ class UltraCircuitBuilder_ : public CircuitBuilderBase<typename ExecutionTrace_:
		this->is_recursive_circuit = recursive;


		[[nodiscard]] bool check_circuit() const { return !_failed; }

		size_t create_ROM_array([[maybe_unused]] const size_t array_size) { return {}; }

Conversation

lucasxia01 commented Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lucasxia01 Nov 22, 2024

Choose a reason for hiding this comment

Uh oh!

lucasxia01 Nov 22, 2024

Choose a reason for hiding this comment

Uh oh!

lucasxia01 Nov 22, 2024

Choose a reason for hiding this comment

Uh oh!

lucasxia01 Nov 22, 2024

Choose a reason for hiding this comment

Uh oh!

codygunton left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codygunton Nov 25, 2024

Choose a reason for hiding this comment

Uh oh!

lucasxia01 Nov 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codygunton Nov 25, 2024

Choose a reason for hiding this comment

Uh oh!

lucasxia01 Nov 25, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lucasxia01 commented Nov 21, 2024 •

edited

Loading

lucasxia01 Nov 25, 2024 •

edited

Loading