Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate #97

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

translate #97

wants to merge 2 commits into from

Conversation

noahfraiture
Copy link
Contributor

Hello,
This PR give the possibility to have single and double quote inside your sentence you want to translate

@AymanLyesri
Copy link
Owner

Am afraid it doesn't work
image

image

image

it should look something like this
image

@noahfraiture
Copy link
Contributor Author

I didn't explain it well. The point of my PR is to treat quote and single quote as char. So you could do
translate hi there > fr, and it would be different that translate "hi there" > fr. The idea is to give the possibility to stuff like : translate his name is "jack" > fr that would translate to Son nom est "jack". So it works as intended, I understand if you don't like it that way but I feel it gives more power to the user

@AymanLyesri
Copy link
Owner

Ah i see, its actually a good feature to have, one thing tho, it dosent work for double quotes, only for single

image

image

@noahfraiture
Copy link
Contributor Author

I'm not sure why but it seems that if the string end with a quote, there's an error. But we still get the result

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants