-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for tooltips #17
Conversation
@gber: We did a hell of a change for libayatana-appindicator recently (autoconf -> cmake). Can you rebase your PR branch please, please? Thanks |
I'm already on it, the only remaining issue is making g-ir-scanner work with the out of tree build, where one part of the header is inside the tree and the other one generated in the build directory. Needs some investigation/experiments. |
39ac33b
to
fc6f9f1
Compare
Something goes wrong with the GTK# bindings code generation, but I have zero experience with GTK# or C#. |
@sunweaver
Apparently the code generator fails to generate some method names, but I'm not sure what causes it. |
I've used this patch in a test program with this code:
The result on Mint with an XFCE is that the tooltip is displayed underneath the icon, if the panel is horizontal, one can only see a light line at the bottom of the screen, no tooltip is visible. For a vertical panel, you see this: EDIT: Full code and sample program here: Betterbird/thunderbird-patches#20 (comment) |
I gave my test program to a few people to play with. So far, I haven't seen an installation where it worked. KDE seems to display the app indicator title, not the tooltip:
@gber : On which platform did you test this? |
We've integrated the application indicator into Betterbird now, see Betterbird/thunderbird-patches#20 (comment). @sunweaver @gber - Any chance to get the tooltips? |
We've decided to take the tooltip patch (fc6f9f1) to Betterbird: It works well enough. We had no luck with the tooltip body, but the title works well enough. On our installations, if the dock/panel/taskbar was at the bottom of the screen, the tooltip was drawn beneath it, that is off-screen (already mentioned in #17 (comment)) and hence invisible. |
Make includes work though a symlink rather than modifying the generated sources. This is necessary so that headers included from the main header work.
An icon, title and text body may be set independently or at once resulting in a single signal. Markup in the text body is not supported for simplicity.
IIRC I tested this with Xfce back then, need to check current platforms (KDE, Xfce, Gnome Shell extension) again.
I've rebased this against master, just the C# binding problem remains. I'll work on this as time permits. |
As I wrote earlier, we've deployed the tooltips for a few months now. Mileage varies, it works best on KDE and Xfce and explicitly doesn't work on Gnome. Of course there is also issue #62 which we had to fix. |
We've rebased the patch, maybe it's useful to someone: |
Superceded finally by #82 |
This also adds version checking macros in order to allow consumers to write backwards-compatible code. Note that this does not update the bindings since I'm unfamiliar with that.