process: add undefined check for query of input() #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semicolon added after 'use strict'
Comment starts with uppercase on line 247 Semicolon on line 256
|
I'm sorry. I have not seen this PR until now. Is it is ready to merge? |
|
@Ayase-252 I think so, I have fixed all linting errors but there seems to be one test failing |
|
@anirudhgiri Thanks, I may proceed the feature in few weeks, since I have some questions to clear about those unit tests 😂. . Stay tuned! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes nodejs#37925 work as intended.
If
process.inputis called without any arguments, "undefined" is printed tostdoutbecause thequeryparameter wasundefinedforrl.question.Adding a check to see if
args[0] === undefinedand setting it to an empty string if true fixes the issue.