Skip to content

feat: export modules that include dependencies #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2023
Merged

feat: export modules that include dependencies #749

merged 1 commit into from
Sep 23, 2023

Conversation

steabert
Copy link
Member

Some dependencies are difficult to handle by external bundlers, especially the node deps replaced for the browser.

In that case, we can allow to e.g.:

import { ... } from 'media-stream-player/heavy'

which already includes those dependencies.
Not everything is bundled though.

Fixes #743

@steabert steabert requested a review from rikteg as a code owner March 23, 2023 08:31
Copy link
Member

@lekoaf lekoaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be documented somewhere?

Some dependencies are difficult to handle by external
bundlers, especially the node deps replaced for the
browser.

In that case, we can allow to e.g.:

```
import { ... } from 'media-stream-player/heavy'
```

which already includes those dependencies.
Not everything is bundled though.
@steabert
Copy link
Member Author

I've updated the docs.

@steabert steabert merged commit 8396c9f into main Sep 23, 2023
@steabert steabert deleted the batteries branch September 23, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BasicPlayer in react application with npm package makes error
2 participants