Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw runtime_error when RunServer fails #99

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

killenheladagen
Copy link
Contributor

By throwing exceptions instead of returning an error code, all errors from RunServer can be handled in the same way, in a single place. Constructor calls inside RunServer already throws runtime_error on failure.

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

Change-Id: Ibb7a57b50a47e80a4370ab66e842548dcbdbb2f7
@killenheladagen killenheladagen requested review from a team as code owners September 4, 2024 09:56
Base automatically changed from raii-capture to main September 9, 2024 12:24
@killenheladagen killenheladagen merged commit 6c859b9 into main Sep 9, 2024
6 checks passed
@killenheladagen killenheladagen deleted the throw-runtime-error branch September 9, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants