Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow RAII in Inference class #95

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Follow RAII in Inference class #95

merged 1 commit into from
Sep 9, 2024

Conversation

killenheladagen
Copy link
Contributor

@killenheladagen killenheladagen commented Aug 30, 2024 •
edited
Loading

Replace 2-phase initialization with an exception-throwing constructor.

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

@killenheladagen killenheladagen requested review from a team as code owners August 30, 2024 15:06
Base automatically changed from rm-using-ns to main September 9, 2024 12:20
@killenheladagen killenheladagen merged commit 5b8c56a into main Sep 9, 2024
6 checks passed
@killenheladagen killenheladagen deleted the raii-inference branch September 9, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madelen-at-work madelen-at-work madelen-at-work approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@killenheladagen @madelen-at-work