Replace parhand with axparameter #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killenheladagen
requested changes
Aug 7, 2024
src/parameter.cpp
Outdated
| } | ||
| ax_parameter_free(ax_parameter); | ||
| g_clear_error(&error); |
There was a problem hiding this comment.
If there are errors more than once from ax_parameter_get, this will only deallocate the last one.
ax_parameter_get() will only set an error when it returns false, so put g_clear_error() inside the if-block instead. No need for it here.
madelen-at-work
force-pushed
the
parameter-api
branch
from
c059463 to
31647b0
Compare
|
tested, +1 |
src/parameter.cpp
Outdated
| Status Parameter::GetValues(ServerContext* context, | ||
| ServerReaderWriter<Response, Request>* stream) { | ||
| // Initialize Parameter Service | ||
| bool Parameter::Init(const bool verbose) |
There was a problem hiding this comment.
See my comments in https://github.com/AxisCommunications/acap-runtime/pull/80/files about constructor instead of two-phase initialization.
madelen-at-work
force-pushed
the
dockerfile-cleanup
branch
from
dbc1491 to
44a5b2f
Compare
madelen-at-work
force-pushed
the
parameter-api
branch
2 times, most recently
from
081c963 to
1fb55df
Compare
madelen-at-work
changed the base branch from
dockerfile-cleanup
to
clang-format
madelen-at-work
force-pushed
the
clang-format
branch
from
b3d3c1d to
532a8e2
Compare
madelen-at-work
force-pushed
the
parameter-api
branch
from
1fb55df to
9aed79c
Compare
madelen-at-work
force-pushed
the
clang-format
branch
2 times, most recently
from
67c905d to
39de532
Compare
madelen-at-work
force-pushed
the
parameter-api
branch
from
9aed79c to
5ab3e6e
Compare
madelen-at-work
force-pushed
the
clang-format
branch
from
39de532 to
a4b81cd
Compare
madelen-at-work
force-pushed
the
parameter-api
branch
from
5ab3e6e to
e69d6cd
Compare
madelen-at-work
force-pushed
the
parameter-api
branch
from
e69d6cd to
041fcdd
Compare
| @@ -35,6 +36,8 @@ class Parameter final : public KeyValueStore::Service { | |||
| private: | |||
| Status GetValues(ServerContext* context, ServerReaderWriter<Response, Request>* stream); | |||
|
|
|||
| AXParameter* ax_parameter; | |||
| GError* _error; | |||
There was a problem hiding this comment.
There is no need for this to be a class member. It can be a local variable in each function it is used.
killenheladagen
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Since axparameter is now included in the SDK let's use it instead of parhand.
Issue ticket number and link
Checklist before requesting a review