-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Acap runtime proto image #77
Conversation
Change-Id: I4cb8389f457fa33fca8109da70238f09ec5851a1
Change-Id: Ie7e63c3c42ac135a6b807819691b592b77a96ca3
Change-Id: I02e4bedc5cfee51acf1c1cb0ba7ddb7581dcfa5d
Change-Id: I2c635bd6044806e1357d43b9f4a6acf50de5ea9b
apis/keyvaluestore.proto
Outdated
@@ -21,7 +21,7 @@ package keyvaluestore; | |||
// A simple key-value storage service | |||
service KeyValueStore { | |||
// Provides a value for each key request | |||
rpc GetValues (stream Request) returns (stream Response) {} | |||
rpc GetValues (Request) returns (Response) {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This requires the parameter api code and test to be updated as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is pushed to main now so you can rebase this PR to pick it up
NB! we do currently have an issue on the unit tests for parameter API on main though, so tests are failing there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests are fixed now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dockerfile.proto looks good. But the plan is to publish it to Docker Hub as well, right? If so a workflow for that would be nice
Should it be part of the ci-cd? |
Might be cleaner to have a separate file |
@madelen-at-work I was thinking that dockerhub has a functionality to automatically rebuild for instance on tag. |
When we open source:d this project we deliberately moved building from Docker Hub to GitHub to be able to keep everything contained in this repo. I would prefer not setting up a new flow in Docker Hub. |
Co-authored-by: Patrik Åkesson <[email protected]>
Co-authored-by: Patrik Åkesson <[email protected]>
Change-Id: I353ec4f90058322b87f8a24ebfdef9c906640377
Co-authored-by: Patrik Åkesson <[email protected]>
Change-Id: I4dce46b382d18d718c6c125f24f245caf887cb7e
Before merging this PR make sure the following remaining parts from closed PR #86 is added:
|
Squashed into one commit and rebased towards main in #96 instead. |
Describe your changes
Adding a new dockerfile to ACAP runtime that builds proto APIs for python.