Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Dockerfiles #74

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Merge Dockerfiles #74

merged 1 commit into from
Aug 19, 2024

Conversation

madelen-at-work
Copy link
Contributor

@madelen-at-work madelen-at-work commented May 3, 2024 •
edited
Loading

Describe your changes

Merged the Dockerfiles for each architecture into one to reduce risk of them diverging.
Updated workflow to work with one file (and work better)

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

@madelen-at-work madelen-at-work changed the base branch from main to workflow-refactor May 6, 2024 06:43
@madelen-at-work madelen-at-work force-pushed the dockerfile-cleanup branch 2 times, most recently from fc02199 to edc4117 Compare May 6, 2024 10:18
@madelen-at-work madelen-at-work changed the base branch from workflow-refactor to main August 15, 2024 10:21
@madelen-at-work madelen-at-work marked this pull request as ready for review August 15, 2024 11:49
@madelen-at-work madelen-at-work requested review from a team as code owners August 15, 2024 11:49
killenheladagen
killenheladagen reviewed Aug 16, 2024
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@madelen-at-work madelen-at-work merged commit d98d1ac into main Aug 19, 2024
13 checks passed
@madelen-at-work madelen-at-work deleted the dockerfile-cleanup branch August 19, 2024 09:55
johan-olsson-work pushed a commit that referenced this pull request Aug 29, 2024
@madelen-at-work @johan-olsson-work
Merge Dockerfiles (#74)
da1d435
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killenheladagen killenheladagen killenheladagen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madelen-at-work @killenheladagen