Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(axstorage)!: Return GString instead of CString #150

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

apljungquist
Copy link
Contributor

No description provided.

`crates/axstorage/src/flex.rs`:
- Return `GString` instead of `CString` because the latter is
  unsound since the safety preconditions of `CString` are not
  satisfied. In particular there is no guarantee that the allocator
  that `CString` will use to free the memory is the same as the one
  used by `axstorage` to allocate the memory.

Change-Id: I5f1844925917de23d4ae1f920c9b65045237f396
@apljungquist apljungquist requested a review from a team as a code owner December 12, 2024 16:54
@apljungquist apljungquist marked this pull request as draft December 12, 2024 17:18
@apljungquist apljungquist changed the title fix(axstorage): Return GString instead of CString fix(axstorage)!: Return GString instead of CString Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant