Skip to content

Conversation

@lg2de
Copy link
Member

@lg2de lg2de commented Oct 19, 2025

Fixes #312.

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

Legal checklist

  • This work is entirely original, it is not derived from any existing code incompatible with the Apache 2.0 License, like FluentAssertions.

@lg2de lg2de requested a review from a team October 19, 2025 13:15
Copy link
Member

@cbersch cbersch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coveralls
Copy link

coveralls commented Oct 19, 2025

Pull Request Test Coverage Report for Build 18631759595

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.512%

Totals Coverage Status
Change from base Build 18631145897: 0.0%
Covered Lines: 12626
Relevant Lines: 12808

💛 - Coveralls

@cbersch cbersch added the feature New feature label Oct 19, 2025
@lg2de
Copy link
Member Author

lg2de commented Oct 19, 2025

Thanks for your review, @cbersch , @ScarletKuro . I found that the renovate bot shall be instructed correctly.
Because I'm not that familiar with renovate, I asked the copilot to create a configuration to restrict the updates according to the relevant projects.
Do you think that is correct?

@cbersch
Copy link
Member

cbersch commented Oct 19, 2025

Thanks for your review, @cbersch , @ScarletKuro . I found that the renovate bot shall be instructed correctly. Because I'm not that familiar with renovate, I asked the copilot to create a configuration to restrict the updates according to the relevant projects. Do you think that is correct?

I think this is correct, given the current capabilities of renovate.
Unfortunately, nuget ranges currently don't work properly with renovate (renovatebot/renovate#37800).
We also need such a distinction for NUnit, the last update was wrong: #254

@lg2de
Copy link
Member Author

lg2de commented Oct 19, 2025

We also need such a distinction for NUnit

I'll do that in a separate PR today.
Tomorrow, when next update should run, we can check the outcome.

@sonarqubecloud
Copy link

@ScarletKuro
Copy link
Contributor

Do you think that is correct?

LGTM

IhateTrains pushed a commit to ParadoxGameConverters/ImperatorToCK3 that referenced this pull request Nov 3, 2025
Updated
[AwesomeAssertions](https://github.com/AwesomeAssertions/AwesomeAssertions)
from 9.2.1 to 9.3.0.

<details>
<summary>Release notes</summary>

_Sourced from [AwesomeAssertions's
releases](https://github.com/AwesomeAssertions/AwesomeAssertions/releases)._

## 9.3.0

<!-- Release notes generated using configuration in .github/release.yml
at main -->

## What's Changed
### New features
* Add support for MSTest V4 by @​lg2de in
AwesomeAssertions/AwesomeAssertions#315
* Exclude member names by @​cbersch in
AwesomeAssertions/AwesomeAssertions#317
### Improvements
* Improve handling of tabulators in string diff visualization by
@​cbersch in
AwesomeAssertions/AwesomeAssertions#313
* Hide internal exception throwing details in stacktrace by @​cbersch in
AwesomeAssertions/AwesomeAssertions#327
### Fixes
* Fix failure message for string matching null subject by @​cbersch in
AwesomeAssertions/AwesomeAssertions#314
### Documentation
* Update docs for 9.3.0 by @​cbersch in
AwesomeAssertions/AwesomeAssertions#333
### Dependencies
* chore(deps): update dependency verify.xunit to 31.0.3 by
@​renovate[bot] in
AwesomeAssertions/AwesomeAssertions#320
* chore(deps): update dependency meziantou.analyzer to 2.0.227 by
@​renovate[bot] in
AwesomeAssertions/AwesomeAssertions#319
* chore(deps): update dependency nunit to 4.4.0 by @​renovate[bot] in
AwesomeAssertions/AwesomeAssertions#321
* chore(deps): update github/codeql-action action to v4 by
@​renovate[bot] in
AwesomeAssertions/AwesomeAssertions#324
* chore(deps): update dependency tunit to 0.74.2 by @​renovate[bot] in
AwesomeAssertions/AwesomeAssertions#322
* chore(deps): update dependency cspell to v9.2.2 by @​renovate[bot] in
AwesomeAssertions/AwesomeAssertions#329
* chore(deps): update dependency bogus to 35.6.5 by @​renovate[bot] in
AwesomeAssertions/AwesomeAssertions#328
* chore(deps): update dependency meziantou.analyzer to 2.0.238 by
@​renovate[bot] in
AwesomeAssertions/AwesomeAssertions#330
* chore(deps): update dependency verify.xunit to 31.0.5 by
@​renovate[bot] in
AwesomeAssertions/AwesomeAssertions#331
* chore(config): migrate renovate config by @​renovate[bot] in
AwesomeAssertions/AwesomeAssertions#332
### Others
* Add renovate configuration for NUnit framework tests by @​lg2de in
AwesomeAssertions/AwesomeAssertions#316

## New Contributors
* @​lg2de made their first contribution in
AwesomeAssertions/AwesomeAssertions#315

**Full Changelog**:
AwesomeAssertions/AwesomeAssertions@9.2.1...9.3.0

Commits viewable in [compare
view](AwesomeAssertions/AwesomeAssertions@9.2.1...9.3.0).
</details>

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=AwesomeAssertions&package-manager=nuget&previous-version=9.2.1&new-version=9.3.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
github-actions bot pushed a commit to saan800/github that referenced this pull request Nov 3, 2025
Updated
[AwesomeAssertions](https://github.com/AwesomeAssertions/AwesomeAssertions)
from 9.2.1 to 9.3.0.

<details>
<summary>Release notes</summary>

_Sourced from [AwesomeAssertions's
releases](https://github.com/AwesomeAssertions/AwesomeAssertions/releases)._

## 9.3.0

<!-- Release notes generated using configuration in .github/release.yml
at main -->

## What's Changed
### New features
* Add support for MSTest V4 by @​lg2de in
AwesomeAssertions/AwesomeAssertions#315
* Exclude member names by @​cbersch in
AwesomeAssertions/AwesomeAssertions#317
### Improvements
* Improve handling of tabulators in string diff visualization by
@​cbersch in
AwesomeAssertions/AwesomeAssertions#313
* Hide internal exception throwing details in stacktrace by @​cbersch in
AwesomeAssertions/AwesomeAssertions#327
### Fixes
* Fix failure message for string matching null subject by @​cbersch in
AwesomeAssertions/AwesomeAssertions#314
### Documentation
* Update docs for 9.3.0 by @​cbersch in
AwesomeAssertions/AwesomeAssertions#333
### Dependencies
* chore(deps): update dependency verify.xunit to 31.0.3 by
@​renovate[bot] in
AwesomeAssertions/AwesomeAssertions#320
* chore(deps): update dependency meziantou.analyzer to 2.0.227 by
@​renovate[bot] in
AwesomeAssertions/AwesomeAssertions#319
* chore(deps): update dependency nunit to 4.4.0 by @​renovate[bot] in
AwesomeAssertions/AwesomeAssertions#321
* chore(deps): update github/codeql-action action to v4 by
@​renovate[bot] in
AwesomeAssertions/AwesomeAssertions#324
* chore(deps): update dependency tunit to 0.74.2 by @​renovate[bot] in
AwesomeAssertions/AwesomeAssertions#322
* chore(deps): update dependency cspell to v9.2.2 by @​renovate[bot] in
AwesomeAssertions/AwesomeAssertions#329
* chore(deps): update dependency bogus to 35.6.5 by @​renovate[bot] in
AwesomeAssertions/AwesomeAssertions#328
* chore(deps): update dependency meziantou.analyzer to 2.0.238 by
@​renovate[bot] in
AwesomeAssertions/AwesomeAssertions#330
* chore(deps): update dependency verify.xunit to 31.0.5 by
@​renovate[bot] in
AwesomeAssertions/AwesomeAssertions#331
* chore(config): migrate renovate config by @​renovate[bot] in
AwesomeAssertions/AwesomeAssertions#332
### Others
* Add renovate configuration for NUnit framework tests by @​lg2de in
AwesomeAssertions/AwesomeAssertions#316

## New Contributors
* @​lg2de made their first contribution in
AwesomeAssertions/AwesomeAssertions#315

**Full Changelog**:
AwesomeAssertions/AwesomeAssertions@9.2.1...9.3.0

Commits viewable in [compare
view](AwesomeAssertions/AwesomeAssertions@9.2.1...9.3.0).
</details>

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=AwesomeAssertions&package-manager=nuget&previous-version=9.2.1&new-version=9.3.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Add support for MSTest v4

4 participants