Fix addded <cstdint> #408
Merged
Fix addded <cstdint> #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In file included from strings.cpp:41:
strings.h:58:25: error: 'uint16_t' was not declared in this scope
58 | std::string U16_to_utf8(uint16_t u16);
| ^~~~~~~~
strings.h:37:1: note: 'uint16_t' is defined in header '<cstdint>'; this is probably fixable by adding '#include <cstdint>'
36 | #include <memory>
+++ |+#include <cstdint>
37 |
strings.cpp:240:13: error: redefinition of 'std::string U16_to_utf8'
240 | std::string U16_to_utf8(uint16_t u16)
| ^~~~~~~~~~~
strings.h:58:13: note: 'std::string U16_to_utf8' previously declared here
58 | std::string U16_to_utf8(uint16_t u16);
| ^~~~~~~~~~~
strings.cpp:240:25: error: 'uint16_t' was not declared in this scope
240 | std::string U16_to_utf8(uint16_t u16)
| ^~~~~~~~
strings.cpp:48:1: note: 'uint16_t' is defined in header '<cstdint>'; this is probably fixable by adding '#include <cstdint>'
47 | #include <vector>
+++ |+#include <cstdint>
|
Formerly it was included in , seems like they changed it in GCC 15. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In file included from strings.cpp:41:
strings.h:58:25: error: 'uint16_t' was not declared in this scope
58 | std::string U16_to_utf8(uint16_t u16);
| ^~~~~~~~
strings.h:37:1: note: 'uint16_t' is defined in header ''; this is probably fixable by adding '#include '
36 | #include
+++ |+#include
37 |
strings.cpp:240:13: error: redefinition of 'std::string U16_to_utf8'
240 | std::string U16_to_utf8(uint16_t u16)
| ^~~~~~~~~~~
strings.h:58:13: note: 'std::string U16_to_utf8' previously declared here
58 | std::string U16_to_utf8(uint16_t u16);
| ^~~~~~~~~~~
strings.cpp:240:25: error: 'uint16_t' was not declared in this scope
240 | std::string U16_to_utf8(uint16_t u16)
| ^~~~~~~~
strings.cpp:48:1: note: 'uint16_t' is defined in header ''; this is probably fixable by adding '#include '
47 | #include
+++ |+#include