Skip to content

Fix issue preventing opening a second dialog immediately after the first dialog closes #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SKProCH merged 1 commit into from
Jul 14, 2026
Merged

Fix issue preventing opening a second dialog immediately after the first dialog closes #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions DialogHost.Avalonia/DialogHost.axaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -788,8 +788,6 @@ public void RemoveDispose(DialogOverlayPopupHost host) {
}

private void RemoveHost(DialogOverlayPopupHost host) {
//NB: _dialogTaskCompletionSource is only set in the case where the dialog is shown with Show
host.DialogTaskCompletionSource.TrySetResult(host.Session.CloseParameter);
host.IsOpen = false;
host.Content = null;

Expand All @@ -800,6 +798,8 @@ private void RemoveHost(DialogOverlayPopupHost host) {
if (_overlayPopupHosts.Count == 0) {
SetAndRaise(IsOpenProperty, ref _isOpen, false);
}

host.DialogTaskCompletionSource.TrySetResult(host.Session.CloseParameter);
}

private void ContentCoverGrid_OnPointerReleased(object sender, PointerReleasedEventArgs e) {
Expand Down