Skip to content

Removes image resolving attempts for empty strings #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SKProCH merged 1 commit into from
Dec 27, 2025
Merged

Removes image resolving attempts for empty strings #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion AsyncImageLoader.Avalonia/AdvancedImage.axaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ private async void UpdateImage(string? source, IAsyncImageLoader? loader) {

var bitmap = await Task.Run(async () => {
try {
if (source == null)
if (string.IsNullOrWhiteSpace(source))
return null;

// A small delay allows to cancel early if the image goes out of screen too fast (eg. scrolling)
Expand Down
4 changes: 2 additions & 2 deletions AsyncImageLoader.Avalonia/ImageBrushLoader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ private static async void OnSourceChanged(ImageBrush imageBrush, AvaloniaPropert

Bitmap? bitmap = null;
try {
if (newValue is not null) {
bitmap = await AsyncImageLoader.ProvideImageAsync(newValue);
if (!string.IsNullOrWhiteSpace(newValue)) {
bitmap = await AsyncImageLoader.ProvideImageAsync(newValue!);
}
}
catch (Exception e) {
Expand Down
2 changes: 1 addition & 1 deletion AsyncImageLoader.Avalonia/ImageLoader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ private static async void OnSourceChanged(Image sender, AvaloniaPropertyChangedE
return new CancellationTokenSource();
});

if (url == null) {
if (string.IsNullOrWhiteSpace(url)) {
((ICollection<KeyValuePair<Image, CancellationTokenSource>>)PendingOperations).Remove(
new KeyValuePair<Image, CancellationTokenSource>(sender, cts));
sender.Source = null;
Expand Down