Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: System.NullReferenceException on Undo #440

Merged
merged 5 commits into from
Jul 29, 2024

Conversation

workgroupengineering
Copy link
Contributor

fixes #425

@workgroupengineering
Copy link
Contributor Author

Do I need to make any other changes? I hope the merge and release takes place soon.

@maxkatz6 maxkatz6 requested review from danipen and Gillibald July 27, 2024 00:50
Co-authored-by: Daniel Peñalba <[email protected]>
Copy link
Collaborator

@danipen danipen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danipen danipen removed the request for review from Gillibald July 27, 2024 18:24
@danipen
Copy link
Collaborator

danipen commented Jul 28, 2024

It seems that the Azure Pipelines task Pack AvaloniaEdit is failing in a consistent way. Any ideas?

##[warning].NET 5 has some compatibility issues with older Nuget versions(<=5.7), so if you are using an older Nuget version(and not dotnet cli) to restore, then the dotnet cli commands (e.g. dotnet build) which rely on such restored packages might fail. To mitigate such error, you can either: (1) - Use dotnet cli to restore, (2) - Use Nuget version 5.8 to restore, (3) - Use global.json using an older sdk version(<=3) to build
##[error]Error: The process 'C:\Program Files\dotnet\dotnet.exe' failed with exit code 1
##[error]An error occurred while trying to pack the files.
Info: Azure Pipelines hosted agents have been updated and now contain .Net 5.x SDK/Runtime along with the older .Net Core version which are currently lts. Unless you have locked down a SDK version for your project(s), 5.x SDK might be picked up which might have breaking behavior as compared to previous versions. You can learn more about the breaking changes here: https://docs.microsoft.com/en-us/dotnet/core/tools/ and https://docs.microsoft.com/en-us/dotnet/core/compatibility/ . To learn about more such changes and troubleshoot, refer here: https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/build/dotnet-core-cli?view=azure-devops#troubleshooting
Finishing: Pack AvaloniaEdit

Any ideas?

@workgroupengineering
Copy link
Contributor Author

I see. Net standard 2.0 does not support Clamp. I fix it tomorrow.

@danipen danipen merged commit 5fa5f8b into AvaloniaUI:master Jul 29, 2024
2 checks passed
@workgroupengineering workgroupengineering deleted the fix/Issue_425 branch July 29, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.NullReferenceException on Undo
3 participants