Change Theme to a DropDown with flyout #433
Conversation
- Little bit of MVVP in here to enable bindings in the AXAML - Drop down, allows me to look at specific themes, As I intend to leverage a little more of the info from the TextMateSharp JSON's HELLO, I'm the author of BlitzSearch ( https://natestah.com ). I'm making heavy use of AvaloniaEdit and there are things that I want to do with it. This would be a small Ice Breaker change, would be awesome if the efforts could align.
-Added a applywindowProperties bool, so that people can opt out ( please review, this probably should default to off or just not exist here ) -Some int->FontStyle reference that came up when I upgraded TextMateSharp -In Demo AXAML's remove "Foreground" setters so that theme can do it's thing on the window.
-undoing the direct project reference. -looks like I fixed up a defaulting the line number to the foreground color change
-Remove apply window updates bool. -Remove duplicated CurrentHighlightRenderer Background/border settings, this is replaced with a new call for but doesn't answer the review note fully.
Head branch was pushed to by a user without write access
|
@Natestah I tried the changes and found some issues:
See the attached video for clarification: testing.mov |
-fallback to the Resource defined Selection brush rather than the first seen when the TextMate Defs don't have a selection background.
|
I think Everything is up-to-date, thank you for time and patience. I'm still learning how to use GitHub and Avalonia |
|
cc @danipen if you want to have another look |
|
I'm rethinking this a bit. We should let users use this functionality, but it shouldn't be mandatory. Some customers likely have custom background or selection colors, so we'd be breaking their styles. Setting styles for the text editor should be the user's responsibility. The TextMate API should be responsible of notifying about theme changes and providing the theme colors. Let me rethink this a bit and I'll do a small refactor. |
We should let users use this functionality, but it shouldn't be mandatory. Some customers likely have custom background or selection colors, so we'd be breaking their styles. Setting styles for the text editor should be the user's responsibility. The TextMate API should only notify about theme changes and provide theme colors.
| @@ -18,7 +18,7 @@ public class ForegroundTextTransformation : TextTransformation | |||
| public Action<Exception> ExceptionHandler { get; set; } | |||
| public int ForegroundColor { get; set; } | |||
| public int BackgroundColor { get; set; } | |||
| public int FontStyle { get; set; } | |||
| public FontStyle FontStyle { get; set; } | |||
There was a problem hiding this comment.
I haven't noticed before, but changing public property type is an ABI breaking change. Might not be critical, but needs to be carefully considered.
There was a problem hiding this comment.
Yes, this API break comes from TextMateSharp ...
HELLO, I'm the author of BlitzSearch ( https://natestah.com ). I'm making heavy use of AvaloniaEdit and there are things that I want to do with it. This would be a small Ice Breaker change, would be awesome if the efforts could align.