Fix ForegroundTextTransformation objects mem leak #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danipen
changed the title
|
@Gillibald please could you review these changes? |
Gillibald
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid heap mem pressure, we're using an ArrayPool to avoid too many
ForegroundTextTransformationallocations.The issue is that if this class holds a reference to this (
TextMateColoringTransformer) viaForegroundTextTransformation.IColorMapinterface implementation. This causes allForegroundTextTransformationsthat live in memory (in the shared array pool) will be referencing theTextMateColoringTransformerinstance, driving a mem leak.The issue can be avoided by passing the dictionary with the color map to the
ForegroundTextTransformationinstead of passing an interface.