Fix ForegroundTextTransformation objects mem leak #373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid heap mem pressure, we're using an ArrayPool to avoid too many
ForegroundTextTransformation
allocations.The issue is that if this class holds a reference to this (
TextMateColoringTransformer
) viaForegroundTextTransformation.IColorMap
interface implementation. This causes allForegroundTextTransformations
that live in memory (in the shared array pool) will be referencing theTextMateColoringTransformer
instance, driving a mem leak.The issue can be avoided by passing the dictionary with the color map to the
ForegroundTextTransformation
instead of passing an interface.