Fix: TextLayer is rendered behind SelectionLayer #342
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The
TextLayer
is rendered behind theSelectionLayer
, which makes the text hard to read when selected. If you style the control and set an opaqueSelectionBrush
then the text is obscured completely.Cause:
The problem is that
TextView.Layers
andTextView.VisualChildren
are out of sync:The
Layers
areSelectionLayer
TextLayer
CaretLayer
but the
VisualChildren
areTextLayer
SelectionLayer
CaretLayer
Fix:
The
LayerCollection
needs to insert the control at the correct index. (The first n visual children should correspond to the n layers in theLayerCollection
.)