Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework the search panel #309

Merged
merged 12 commits into from
Mar 2, 2023
Merged

Rework the search panel #309

merged 12 commits into from
Mar 2, 2023

Conversation

danipen
Copy link
Collaborator

@danipen danipen commented Mar 1, 2023 •
edited
Loading

  • Use SVG icons.
  • Use Avalonia's fluent theme color palette.
  • Improve look and feel.
  • Update the SearchResult marker brush.
  • Don't use corner radius for search results.
  • Improve the search panel message
    • Display the total of matches found
    • Display the selected index of the current search result / total

Some demo:
find-replace

@danipen
Rework the search panel styles
eb9220c 
- Use SVG icons.
- Use Avalonia's fluent theme color palette.
- Improve look and feel.
- Update the SearchResult marker brush.
- Don't use corner radius for search results.
@danipen
Remove unused resources
8bbf4ba
@danipen danipen requested a review from Gillibald March 1, 2023 10:37
@danipen danipen changed the title Rework the search panel [WIP]Rework the search panel Mar 1, 2023
@danipen
Improve the search panel message
93abd23 
- Display the total of matches found
- Display the selected index of the current search result / total
@danipen
Undo format changes, and setup method visibility. Make it static.
e6e27c1
@danipen danipen changed the title [WIP]Rework the search panel Rework the search panel Mar 1, 2023
@danipen danipen changed the title Rework the search panel [WIP]Rework the search panel Mar 1, 2023
@danipen danipen changed the title [WIP]Rework the search panel Rework the search panel Mar 1, 2023
@danipen danipen marked this pull request as draft March 2, 2023 07:50
@danipen
Move the SetSearchResultsBrush property to the TextEditor
8d2c6bb 
This way you don't need to wait to the control template to be applied in order to change the search result bg color.
@danipen
Use non-bordered drawings for the search result geometry
b3f746b
@danipen danipen marked this pull request as ready for review March 2, 2023 08:53
@danipen danipen merged commit 9333d9f into master Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gillibald Gillibald Gillibald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danipen @Gillibald