Fixes VisualLine leak #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danipen
requested changes
Oct 6, 2022
| @@ -890,7 +890,7 @@ protected override Size MeasureOverride(Size availableSize) | |||
| { | |||
| // no document -> create empty list of lines | |||
| _allVisualLines = new List<VisualLine>(); | |||
| _visibleVisualLines = new ReadOnlyCollection<VisualLine>(_allVisualLines.ToArray()); | |||
| _visibleVisualLines = new ReadOnlyCollection<VisualLine>(_allVisualLines); | |||
There was a problem hiding this comment.
@Gillibald be careful with this change. I think we need to assign a copy of the collection. I already fixed that issue in this PR #137. Please take a look.
Also, see the upstream project implementation. I'd say that is needed otherwise causes the issue described in #137:
- https://github.com/icsharpcode/AvalonEdit/blob/b6fe189e7be4a8b650c0c670fdac8b839800d9cc/ICSharpCode.AvalonEdit/Rendering/TextView.cs#L927
- https://github.com/icsharpcode/AvalonEdit/blob/b6fe189e7be4a8b650c0c670fdac8b839800d9cc/ICSharpCode.AvalonEdit/Rendering/TextView.cs#L1025
Gillibald
force-pushed
the
fixes/visualLineLeak
branch
from
2a1f2c1 to
0a052a3
Compare
Gillibald
force-pushed
the
fixes/visualLineLeak
branch
from
0a052a3 to
b284999
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a fix that removes a VisualLineDrawingVisual from the logical tree on VisualLine.Dispose