Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try/catch exceptions for override methods and events #213

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Try/catch exceptions for override methods and events #213

merged 1 commit into from
Feb 22, 2022

Conversation

danipen
Copy link
Collaborator

@danipen danipen commented Feb 22, 2022

It prevents the app from crashing if something goes wrong.

@danipen danipen requested review from Takoooooo and miryamGSM and removed request for Takoooooo February 22, 2022 10:40
miryamGSM
miryamGSM approved these changes Feb 22, 2022
View reviewed changes
Copy link

@miryamGSM miryamGSM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danipen danipen merged commit 272a695 into master Feb 22, 2022
@Takoooooo Takoooooo deleted the protect-transformer-exceptions branch November 30, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miryamGSM miryamGSM miryamGSM approved these changes

@Takoooooo Takoooooo Awaiting requested review from Takoooooo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danipen @miryamGSM