D2D Enable color font support #1884
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grokys
reviewed
Sep 9, 2018
| @@ -265,14 +268,17 @@ public void DrawText(IBrush foreground, Point origin, IFormattedTextImpl text) | |||
| { | |||
| var impl = (FormattedTextImpl)text; | |||
|
|
|||
| impl.ApplyDrawingEffects(this); | |||
There was a problem hiding this comment.
Why are the drawing effects applied and removed each time the text is rendered? Why not just apply them when the FormattedTextImpl is created?
There was a problem hiding this comment.
We need a render target to construct the effect brush. I would love to create the brush in ApplySpan. I assumed the FormattedText is only rendered once. That was obviously wrong. There could be a flag that is set when ApplyDrawingEffects is called to avoid recreation and dispose the brush when FormattedTextImpl is disposed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It removes the need for a custom TextRenderer and enables color fonts that way.
A custom TextRenderer is needed to supply a drawing effect to a text range. This was done due to a limitation of SharpDX.
Color fonts should now work and the rendering of text should be better performing. Ligatures should also work with the D2D backend.
Fixes: #1817