Fix DataGrid scroll chaining at layout-rounded boundaries - #256
Merged
Conversation
This was referenced Aug 3, 2026
Merged
This was referenced Aug 7, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes DataGrid preventing scroll chaining when it has reached a vertically scrollable boundary.
At fractional render scaling, layout rounding can produce row heights that are not exactly representable. For example, a 30 DIP row becomes 30.4 DIP at 125% scaling. Accumulating these values can leave a tiny residual
scrollHeightafter the DataGrid reaches the bottom.The previous exact comparison treated that residual as a valid scroll distance, causing
UpdateScrollto returntrueand mark the input event as handled. As a result, the parentScrollViewercould not continue scrolling.This change compares
scrollHeightagainstLayoutHelper.LayoutEpsilon, treating layout-level floating-point residuals as zero and allowing scroll chaining at the boundary.