DataGrid: ScrollBar context menu commands don't work as expected

[zrt2399]

Describe the bug

When using a DataGrid, several commands in the ScrollBar context menu do not behave as expected.

The following menu items are affected:

• Scroll to Top
• Scroll to Bottom
• Page Up
• Page Down
• Left Edge
• Right Edge

These commands do not scroll to the expected position.

To Reproduce

1. Run the Avalonia.Controls.DataGrid sample project.

2. Right-click the ScrollBar.

3. Click any of the following context menu commands:

   • Scroll to Top
   • Scroll to Bottom
   • Page Up
   • Page Down
   • Left Edge
   • Right Edge

Expected behavior

No response

Avalonia version

12.1.0

OS

No response

Additional context

AvaloniaUI/Avalonia#19413

[zrt2399]

It looks like ScrollToHome() and ScrollToEnd() should raise LargeDecrement and LargeIncrement respectively instead of SmallDecrement and SmallIncrement.

public void ScrollToHome()
{
    SetCurrentValue(ValueProperty, Minimum);
-   OnScroll(ScrollEventType.SmallDecrement);
+   OnScroll(ScrollEventType.LargeDecrement);
}

public void ScrollToEnd()
{
    SetCurrentValue(ValueProperty, Maximum);
-   OnScroll(ScrollEventType.SmallIncrement);
+   OnScroll(ScrollEventType.LargeIncrement);
}

[timunie]

Could you open a PR with your suggestions for testing?

[zrt2399]

Could you open a PR with your suggestions for testing?

Thanks for your reply! Before opening a PR, I'd like to see if anyone else has a better idea.

[timunie]

A draft PR with just the changes should create a package for testing, that's why I suggested it.

[zrt2399]

Got it. I'll create a draft PR later.