Further improvements to auto complete box#500
Open
geskill wants to merge 2 commits intoAvaloniaCommunity:masterfrom
Open
Further improvements to auto complete box#500geskill wants to merge 2 commits intoAvaloniaCommunity:masterfrom
geskill wants to merge 2 commits intoAvaloniaCommunity:masterfrom
Conversation
- Add AutoCompleteBox support for InnerLeftContent and InnerRightContent. - Add AutoCompleteBox support for Label and UseFloatingWatermark.
Collaborator
|
Will you further improve this control? Probably this is can be done in single PR, instead of splitting to many small ones |
Contributor
Author
|
i'd love to, but I don't have much time, and XAML isn't my area of expertise. kudos to you, really great work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We added basic styling support in a previous pr #494
This pr goes further, taking advantage of the fact that under the hood the AutoCompleteBox is a
TemplatedControlusing a TextBox and for the TextBox we already have great material styling support.What this pr provides
Limitations