Added Combobox dense class to be consistent with TextBox dense class #462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
WhiteMohawk
commented
May 27, 2025
WhiteMohawk
commented
- added .dense class to ComboBox Theme as an equivalent to the TextBox Theme
- Changed vOffset from -8 to -4 in RectHollowClipConverter as it interfered with clipping in border when in dense class and nothing was selected and not focused (floating label is in control and not in border so clipping should amso not occur). Doesn't seem to have an impact on other controls in demopages for TextBoxes and ComboBoxes
- Added ComboBoxDense in ComboBoxesDemo page
…x Theme * Changed vOffset from -8 to -4 in RectHollowClipConverter as it interfered with clipping in border when in dense class and nothing was selected and not focused (floating label is in control and not in border so clipping should amso not occur). Doesn't seem to have an impact on other controls in demopages for TextBoxes and ComboBoxes * Added ComboBoxDense in ComboBoxesDemo page
SKProCH
approved these changes
May 27, 2025
Collaborator
|
@WhiteMohawk can you reply to my review question? |
SKProCH
approved these changes
Jul 16, 2025
This was referenced Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.