Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better UI for Core selector elements #2237

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

FabienLelaquais
Copy link
Member

Addresses #2232.

  • Minor rewording.
  • Added customization for field name in Filter and Sort.

What type of PR is this? (check all applicable)

  • Refactor

  • Feature

  • Bug Fix

  • Optimization

  • Documentation Update

  • Does this solution meet the acceptance criteria of the related issue?

  • Is the related issue checklist completed?

  • Was the documentation updated, or a dedicated issue for documentation created? (If applicable)

* Added customization for field name in Filter and Sort.
@FabienLelaquais FabienLelaquais added 📈 Improvement Improvement of a feature. 🟨 Priority: Medium Not blocking but should be addressed GUI: Front-End labels Nov 12, 2024
@FabienLelaquais FabienLelaquais self-assigned this Nov 12, 2024
Copy link
Contributor

github-actions bot commented Nov 12, 2024

Coverage report for ./frontend/taipy

Caution

Coverage does not meet threshold
Statements coverage not met for global: expected >=80%, but got 52.07920792079208%

St.
Category Percentage Covered / Total
🔴 Statements 52.08% 263/505
🔴 Branches 21.75% 67/308
🔴 Functions 14.66% 17/116
🔴 Lines 53.42% 242/453

Test suite run success

7 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 8aa7b30

Copy link
Contributor

github-actions bot commented Nov 12, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19266 16753 87% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
taipy/gui_core/_adapters.py 52% 🟢
taipy/gui_core/filters.py 65% 🟢
TOTAL 59% 🟢

updated for commit: 8aa7b30 by action🐍

Copy link
Contributor

Coverage report for ./frontend/taipy-gui

Caution

Coverage does not meet threshold
Branches coverage not met for global: expected >=80%, but got 69.31407942238266%

St.
Category Percentage Covered / Total
🟢 Statements 87.84% 3402/3873
🟡 Branches
69.31% (+0.02% 🔼)
2304/3324
🟢 Functions 83.64% 629/752
🟢 Lines 88.3% 3148/3565
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / TableFilter.tsx
92.86%
76.85% (-0.29% 🔻)
89.66% 93.28%

Test suite run success

681 tests passing in 47 suites.

Report generated by 🧪jest coverage report action from 71d2c3c

FredLL-Avaiga
FredLL-Avaiga previously approved these changes Nov 12, 2024
Copy link
Member

@FredLL-Avaiga FredLL-Avaiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one question

frontend/taipy-gui/src/components/Taipy/TableFilter.tsx Outdated Show resolved Hide resolved
@FabienLelaquais FabienLelaquais merged commit 5ba8435 into develop Nov 12, 2024
58 of 61 checks passed
@FabienLelaquais FabienLelaquais deleted the feature/#2232-core-selector-ui-changes branch November 12, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI: Front-End 📈 Improvement Improvement of a feature. 🟨 Priority: Medium Not blocking but should be addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants