fix #1814 update_content for debug off #2187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FredLL-Avaiga
requested changes
Oct 30, 2024
There was a problem hiding this comment.
Tx @rohitdash08
I cannot run your code, can you fix it
The linter agrees with me :-)
|
I'm not even sure we want to fix this issue ... |
|
Are you still working on this @rohitdash08 ? |
|
@FredLL-Avaiga, No I'm not working on this as we can use chat control with streaming. |
|
no use case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix #1814
Description:
Fixes issue with update_content() behavior inconsistency in debug vs. non-debug modes.
Summary of Changes:
Introduced a queue-based system (UpdateQueue) to batch and control the frequency of updates for partials.
Implemented two batch intervals:
STREAM_MODE_BATCH_INTERVAL for smooth updates during streaming (0.05s).
STANDARD_BATCH_INTERVAL for non-streaming updates (0.2s).
Added thread safety using locks to ensure consistent updates and prevent race conditions.
Created a new method _process_updates() to handle queued updates and apply only the most recent change.
Added a force_update() method for forced updates when necessary.
Impact:
This fix addresses the "chunky" updates observed when debug mode is off, ensuring smoother and more consistent content updates across all modes.